From 8cfcbaa12c1c353cfb283b4d5f18e9d12ca48989 Mon Sep 17 00:00:00 2001 From: Scott Wilson Date: Mon, 11 Nov 2024 13:17:25 -0800 Subject: [PATCH] fix: correct secret reference validation check to permit referencing the same secret multiple times and improve error message --- .../src/services/secret-v2-bridge/secret-v2-bridge-service.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts b/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts index 75b7fcca9..6b9740ffd 100644 --- a/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts +++ b/backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts @@ -150,9 +150,9 @@ export const secretV2BridgeServiceFactory = ({ } }); - if (referredSecrets.length !== references.length) + if (new Set(referredSecrets.map((sec) => sec.key)).size !== new Set(references.map((sec) => sec.secretKey)).size) throw new BadRequestError({ - message: `Referenced secret not found. Found only ${diff( + message: `Referenced secret(s) not found: ${diff( references.map((el) => el.secretKey), referredSecrets.map((el) => el.key) ).join(",")}`