Address PR suggestions

This commit is contained in:
Carlos Monastyrski
2025-11-14 17:46:19 -03:00
parent abe4b127f9
commit 8d3b02e66d
2 changed files with 9 additions and 24 deletions
@@ -572,6 +572,7 @@ interface UserActorMetadata {
email?: string | null; email?: string | null;
username: string; username: string;
permission?: Record<string, unknown>; permission?: Record<string, unknown>;
authMethod?: string;
} }
interface ServiceActorMetadata { interface ServiceActorMetadata {
@@ -2662,10 +2663,6 @@ interface OrgAdminBypassSSOEvent {
interface UserLoginEvent { interface UserLoginEvent {
type: EventType.USER_LOGIN; type: EventType.USER_LOGIN;
metadata: { metadata: {
email: string;
userAgent: string;
ipAddress: string;
authMethod: string;
organizationId?: string; organizationId?: string;
organizationName?: string; organizationName?: string;
authProvider?: string; authProvider?: string;
@@ -2675,12 +2672,8 @@ interface UserLoginEvent {
interface SelectOrganizationEvent { interface SelectOrganizationEvent {
type: EventType.SELECT_ORGANIZATION; type: EventType.SELECT_ORGANIZATION;
metadata: { metadata: {
email: string;
userAgent: string;
ipAddress: string;
organizationId: string; organizationId: string;
organizationName: string; organizationName: string;
authMethod: string;
}; };
} }
@@ -465,16 +465,14 @@ export const authLoginServiceFactory = ({
metadata: { metadata: {
email: userEnc.email, email: userEnc.email,
userId: userEnc.userId, userId: userEnc.userId,
username: userEnc.username username: userEnc.username,
authMethod
} }
}, },
event: { event: {
type: EventType.USER_LOGIN, type: EventType.USER_LOGIN,
metadata: { metadata: {
email, organizationId
userAgent,
ipAddress: ip,
authMethod
} }
} }
}); });
@@ -682,18 +680,15 @@ export const authLoginServiceFactory = ({
metadata: { metadata: {
email: user.email, email: user.email,
userId: user.id, userId: user.id,
username: user.username username: user.username,
authMethod: decodedToken.authMethod
} }
}, },
event: { event: {
type: EventType.SELECT_ORGANIZATION, type: EventType.SELECT_ORGANIZATION,
metadata: { metadata: {
email: user.email || "",
userAgent,
ipAddress,
organizationId, organizationId,
organizationName: selectedOrg.name, organizationName: selectedOrg.name
authMethod: decodedToken.authMethod
} }
} }
}); });
@@ -1102,16 +1097,13 @@ export const authLoginServiceFactory = ({
metadata: { metadata: {
email: userEnc.email, email: userEnc.email,
userId: userEnc.userId, userId: userEnc.userId,
username: userEnc.username username: userEnc.username,
authMethod: decodedProviderToken.authMethod
} }
}, },
event: { event: {
type: EventType.USER_LOGIN, type: EventType.USER_LOGIN,
metadata: { metadata: {
email,
userAgent,
ipAddress: ip,
authMethod: decodedProviderToken.authMethod,
organizationId, organizationId,
...(isAuthMethodSaml(decodedProviderToken.authMethod) && { ...(isAuthMethodSaml(decodedProviderToken.authMethod) && {
authProvider: decodedProviderToken.authMethod authProvider: decodedProviderToken.authMethod