From 8ddfe7b6e98fde1683e6d9966fd2f360ee4819cd Mon Sep 17 00:00:00 2001
From: Daniel Hougaard <daniel@infisical.com>
Date: Mon, 26 Aug 2024 20:53:43 +0400
Subject: [PATCH] Update secret-approval-request-fns.ts

---
 .../secret-approval-request-fns.ts            | 28 +++++++++----------
 1 file changed, 13 insertions(+), 15 deletions(-)

diff --git a/backend/src/ee/services/secret-approval-request/secret-approval-request-fns.ts b/backend/src/ee/services/secret-approval-request/secret-approval-request-fns.ts
index 39b07786c..01b2451ac 100644
--- a/backend/src/ee/services/secret-approval-request/secret-approval-request-fns.ts
+++ b/backend/src/ee/services/secret-approval-request/secret-approval-request-fns.ts
@@ -28,21 +28,19 @@ export const sendApprovalEmailsFn = async ({
 
   // now we need to go through each of the reviewers and print out all the commits that they need to approve
   for await (const reviewerUser of policy.userApprovers) {
-    if (reviewerUser) {
-      await smtpService.sendMail({
-        recipients: [reviewerUser?.email as string],
-        subjectLine: "Infisical Secret Change Request",
+    await smtpService.sendMail({
+      recipients: [reviewerUser?.email as string],
+      subjectLine: "Infisical Secret Change Request",
 
-        substitutions: {
-          firstName: reviewerUser.firstName,
-          projectName: project.name,
-          organizationName: project.organization.name,
-          approvalUrl: `${cfg.isDevelopmentMode ? "https" : "http"}://${cfg.SITE_URL}/project/${
-            project.id
-          }/approval?requestId=${secretApprovalRequest.id}`
-        },
-        template: SmtpTemplates.SecretApprovalRequestNeedsReview
-      });
-    }
+      substitutions: {
+        firstName: reviewerUser.firstName,
+        projectName: project.name,
+        organizationName: project.organization.name,
+        approvalUrl: `${cfg.isDevelopmentMode ? "https" : "http"}://${cfg.SITE_URL}/project/${
+          project.id
+        }/approval?requestId=${secretApprovalRequest.id}`
+      },
+      template: SmtpTemplates.SecretApprovalRequestNeedsReview
+    });
   }
 };