improvements: address feedback

This commit is contained in:
Scott Wilson
2025-07-17 15:27:28 -07:00
parent 1e08b3cdc2
commit 8df53dde3b
10 changed files with 10 additions and 40 deletions
@@ -96,10 +96,7 @@ export const OrgPermissionAdminConsoleRow = ({ isEditable, control, setValue }:
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{PERMISSION_ACTIONS.map(({ action, label }) => { {PERMISSION_ACTIONS.map(({ action, label }) => {
return ( return (
@@ -146,10 +146,7 @@ export const OrgPermissionAppConnectionRow = ({ isEditable, control, setValue }:
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{PERMISSION_ACTIONS.map(({ action, label }) => { {PERMISSION_ACTIONS.map(({ action, label }) => {
return ( return (
@@ -134,10 +134,7 @@ export const OrgPermissionBillingRow = ({ isEditable, control, setValue }: Props
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{PERMISSION_ACTIONS.map(({ action, label }) => { {PERMISSION_ACTIONS.map(({ action, label }) => {
return ( return (
@@ -143,10 +143,7 @@ export const OrgGatewayPermissionRow = ({ isEditable, control, setValue }: Props
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{PERMISSION_ACTIONS.map(({ action, label }) => { {PERMISSION_ACTIONS.map(({ action, label }) => {
return ( return (
@@ -167,10 +167,7 @@ export const OrgPermissionGroupRow = ({ isEditable, control, setValue }: Props)
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{PERMISSION_ACTIONS.map(({ action, label }) => { {PERMISSION_ACTIONS.map(({ action, label }) => {
return ( return (
@@ -177,10 +177,7 @@ export const OrgPermissionIdentityRow = ({ isEditable, control, setValue }: Prop
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{PERMISSION_ACTIONS.map(({ action, label }) => { {PERMISSION_ACTIONS.map(({ action, label }) => {
return ( return (
@@ -93,10 +93,7 @@ export const OrgPermissionKmipRow = ({ isEditable, control, setValue }: Props) =
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{PERMISSION_ACTIONS.map(({ action, label }) => { {PERMISSION_ACTIONS.map(({ action, label }) => {
return ( return (
@@ -90,10 +90,7 @@ export const OrgPermissionSecretShareRow = ({ isEditable, control, setValue }: P
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{PERMISSION_ACTIONS.map(({ action, label }) => { {PERMISSION_ACTIONS.map(({ action, label }) => {
return ( return (
@@ -90,10 +90,7 @@ export const OrgRoleWorkspaceRow = ({ isEditable, control, setValue }: Props) =>
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{PERMISSION_ACTIONS.map(({ action, label }) => { {PERMISSION_ACTIONS.map(({ action, label }) => {
return ( return (
@@ -180,10 +180,7 @@ export const RolePermissionRow = ({ isEditable, title, formName, control, setVal
</Tr> </Tr>
{isRowExpanded && ( {isRowExpanded && (
<Tr> <Tr>
<Td <Td colSpan={3} className="border-mineshaft-500 bg-mineshaft-900 p-8">
colSpan={3}
className={`bg-mineshaft-900 px-0 py-0 ${isRowExpanded && "border-mineshaft-500 p-8"}`}
>
<div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4"> <div className="flex flex-grow flex-wrap justify-start gap-x-8 gap-y-4">
{getPermissionList(formName).map(({ action, label }) => { {getPermissionList(formName).map(({ action, label }) => {
return ( return (