awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 11:27:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: made all update fields optional

Browse Source
This commit is contained in:
Daniel Hougaard
2024-10-02 20:09:31 +04:00
parent 67a6deed72
commit 8ed04d0b75
3 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/server/routes/v1/integration-router.ts
+3 -3
View File
@@ -131,9 +131,9 @@ export const registerIntegrationRouter = async (server: FastifyZodProvider) => {
.default("/") .default("/")
.transform(removeTrailingSlash) .transform(removeTrailingSlash)
.describe(INTEGRATION.UPDATE.secretPath), .describe(INTEGRATION.UPDATE.secretPath),
targetEnvironment: z.string().trim().describe(INTEGRATION.UPDATE.targetEnvironment), targetEnvironment: z.string().trim().optional().describe(INTEGRATION.UPDATE.targetEnvironment),
owner: z.string().trim().describe(INTEGRATION.UPDATE.owner), owner: z.string().trim().optional().describe(INTEGRATION.UPDATE.owner),
environment: z.string().trim().describe(INTEGRATION.UPDATE.environment), environment: z.string().trim().optional().describe(INTEGRATION.UPDATE.environment),
metadata: IntegrationMetadataSchema.optional() metadata: IntegrationMetadataSchema.optional()
}), }),
response: { response: {
backend/src/services/integration/integration-service.ts
+11 -6
View File
@@ -150,12 +150,17 @@ export const integrationServiceFactory = ({
); );
ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Edit, ProjectPermissionSub.Integrations); ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Edit, ProjectPermissionSub.Integrations);
ForbiddenError.from(permission).throwUnlessCan( const newEnvironment = environment || integration.environment.slug;
ProjectPermissionActions.Read, const newSecretPath = secretPath || integration.secretPath;
subject(ProjectPermissionSub.Secrets, { environment, secretPath })
);
const folder = await folderDAL.findBySecretPath(integration.projectId, environment, secretPath); if (environment || secretPath) {
ForbiddenError.from(permission).throwUnlessCan(
ProjectPermissionActions.Read,
subject(ProjectPermissionSub.Secrets, { environment: newEnvironment, secretPath: newSecretPath })
);
}
const folder = await folderDAL.findBySecretPath(integration.projectId, newEnvironment, newSecretPath);
if (!folder) throw new NotFoundError({ message: "Folder path not found" }); if (!folder) throw new NotFoundError({ message: "Folder path not found" });
const updatedIntegration = await integrationDAL.updateById(id, { const updatedIntegration = await integrationDAL.updateById(id, {
@@ -174,7 +179,7 @@ export const integrationServiceFactory = ({
await secretQueueService.syncIntegrations({ await secretQueueService.syncIntegrations({
environment: folder.environment.slug, environment: folder.environment.slug,
secretPath, secretPath: newSecretPath,
projectId: folder.projectId projectId: folder.projectId
}); });
backend/src/services/integration/integration-types.ts
+4 -4
View File
@@ -48,10 +48,10 @@ export type TUpdateIntegrationDTO = {
app?: string; app?: string;
appId?: string; appId?: string;
isActive?: boolean; isActive?: boolean;
secretPath: string; secretPath?: string;
targetEnvironment: string; targetEnvironment?: string;
owner: string; owner?: string;
environment: string; environment?: string;
metadata?: { metadata?: {
secretPrefix?: string; secretPrefix?: string;
secretSuffix?: string; secretSuffix?: string;