improvements: address feedback

docs/internals/permissions/project-permissions.mdx

@@ -135,6 +135,18 @@ Below is a comprehensive list of all available project-level subjects and their
 | `edit`   | Modify token properties                  |
 | `delete` | Revoke or remove service tokens          |
 
+#### Subject: `app-connections`
+
+Supports conditions and permission inversion
+
+| Action                    | Description                        |
+| ------------------------- | ---------------------------------- |
+| `read-app-connections`    | View app connection configurations |
+| `create-app-connections`  | Create new app connections         |
+| `edit-app-connections`    | Modify existing app connections    |
+| `delete-app-connections`  | Remove app connections             |
+| `connect-app-connections` | Use app connections                |
+
 ### Secrets Management
 
 #### Subject: `secrets`

frontend/src/components/secret-rotations-v2/forms/SecretRotationV2ConnectionField.tsx

@@ -107,7 +107,7 @@ export const SecretRotationV2ConnectionField = ({ onChange: callback, isUpdate }
       {!isUpdate && !isPending && !availableConnections?.length && !canCreateConnection && (
         <p className="-mt-2.5 mb-2.5 text-xs text-yellow">
           <FontAwesomeIcon className="mr-1" size="xs" icon={faInfoCircle} />
-          You do not have access to any ${appName} Connections. Contact an admin to create one.
+          You do not have access to any {appName} Connections. Contact an admin to create one.
         </p>
       )}
       <AddAppConnectionModal

frontend/src/components/secret-scanning/forms/SecretScanningDataSourceConnectionField.tsx

@@ -108,7 +108,7 @@ export const SecretScanningDataSourceConnectionField = ({
       {!isUpdate && !isPending && !availableConnections?.length && !canCreateConnection && (
         <p className="-mt-2.5 mb-2.5 text-xs text-yellow">
           <FontAwesomeIcon className="mr-1" size="xs" icon={faInfoCircle} />
-          You do not have access to any ${connectionName} Connections. Contact an admin to create
+          You do not have access to any {connectionName} Connections. Contact an admin to create
           one.
         </p>
       )}

frontend/src/components/secret-syncs/forms/SecretSyncConnectionField.tsx

@@ -91,7 +91,7 @@ export const SecretSyncConnectionField = ({ onChange: callback }: Props) => {
       {!isPending && !availableConnections?.length && !canCreateConnection && (
         <p className="-mt-2.5 mb-2.5 text-xs text-yellow">
           <FontAwesomeIcon className="mr-1" size="xs" icon={faInfoCircle} />
-          You do not have access to any ${appName} Connections. Contact an admin to create one.
+          You do not have access to any {appName} Connections. Contact an admin to create one.
         </p>
       )}
       <AddAppConnectionModal

frontend/src/hooks/api/appConnections/mutations.tsx

@@ -6,7 +6,6 @@ import {
   TAppConnectionResponse,
   TCreateAppConnectionDTO,
   TDeleteAppConnectionDTO,
-  TMigrateAppConnectionDTO,
   TUpdateAppConnectionDTO
 } from "@app/hooks/api/appConnections/types";
 
@@ -62,21 +61,3 @@ export const useDeleteAppConnection = () => {
     }
   });
 };
-
-export const useMigrateAppConnection = () => {
-  const queryClient = useQueryClient();
-  return useMutation({
-    mutationFn: async ({ connectionId, app }: TMigrateAppConnectionDTO) => {
-      const { data } = await apiRequest.post(
-        `/api/v1/app-connections/${app}/${connectionId}/migrate`
-      );
-
-      return data;
-    },
-    onSuccess: ({ projectId, app }) => {
-      queryClient.invalidateQueries({ queryKey: appConnectionKeys.list(projectId) });
-      queryClient.invalidateQueries({ queryKey: appConnectionKeys.listAvailable(app, projectId) });
-      // queryClient.invalidateQueries({ queryKey: appConnectionKeys.byId(app, connectionId) });
-    }
-  });
-};

frontend/src/hooks/api/appConnections/types/index.ts

@@ -1,5 +1,3 @@
-import { ProjectType } from "@app/hooks/api/workspace/types";
-
 import { AppConnection } from "../enums";
 import { TOnePassConnection } from "./1password-connection";
 import { TAppConnectionOption } from "./app-options";
@@ -196,22 +194,18 @@ export type TDeleteAppConnectionDTO = {
 //   [AppConnection.Okta]: TOktaConnection;
 // };
 
-export type TMigrateAppConnectionDTO = {
+// scott: we will need this once we have individual app connection page
-  app: AppConnection;
+// export type AppConnectionUsage = {
-  connectionId: string;
+//   projects: Array<{
-};
+//     id: string;
-
+//     name: string;
-export type AppConnectionUsage = {
+//     slug: string;
-  projects: Array<{
+//     type: ProjectType;
-    id: string;
+//     resources: {
-    name: string;
+//       secretSyncs: Array<{ id: string; name: string }>;
-    slug: string;
+//       externalCas: Array<{ id: string; name: string }>;
-    type: ProjectType;
+//       secretRotations: Array<{ id: string; name: string }>;
-    resources: {
+//       dataSources: Array<{ id: string; name: string }>;
-      secretSyncs: Array<{ id: string; name: string }>;
+//     };
-      externalCas: Array<{ id: string; name: string }>;
+//   }>;
-      secretRotations: Array<{ id: string; name: string }>;
+// };
-      dataSources: Array<{ id: string; name: string }>;
-    };
-  }>;
-};

frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AddAppConnectionModal.tsx

@@ -31,7 +31,7 @@ const Content = ({ onComplete, projectId, projectType, app }: ContentProps) => {
     return (
       <AppConnectionForm
         onComplete={onComplete}
-        onBack={() => setSelectedApp(null)}
+        onBack={app ? undefined : () => setSelectedApp(null)}
         app={(app ?? selectedApp)!}
         projectId={projectId}
       />