awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-10 14:28:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2755 from Infisical/empty-secret-value-fixes

Browse Source 
Fix: Handle Empty Secret Values in Update, Bulk Create and Bulk Update Secret(s)
This commit is contained in:
Scott Wilson
2024-11-19 08:45:38 -08:00
committed by GitHub
parent 61d516ef35 61263b9384
commit 907537f7c0
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts
+9 -8
View File
@@ -414,12 +414,13 @@ export const secretV2BridgeServiceFactory = ({
type: KmsDataKey.SecretManager, type: KmsDataKey.SecretManager,
projectId projectId
}); });
const encryptedValue = secretValue const encryptedValue =
? { typeof secretValue === "string"
encryptedValue: secretManagerEncryptor({ plainText: Buffer.from(secretValue) }).cipherTextBlob, ? {
references: getAllSecretReferences(secretValue).nestedReferences encryptedValue: secretManagerEncryptor({ plainText: Buffer.from(secretValue) }).cipherTextBlob,
} references: getAllSecretReferences(secretValue).nestedReferences
: {}; }
: {};
if (secretValue) { if (secretValue) {
const { nestedReferences, localReferences } = getAllSecretReferences(secretValue); const { nestedReferences, localReferences } = getAllSecretReferences(secretValue);
@@ -1165,7 +1166,7 @@ export const secretV2BridgeServiceFactory = ({
const newSecrets = await secretDAL.transaction(async (tx) => const newSecrets = await secretDAL.transaction(async (tx) =>
fnSecretBulkInsert({ fnSecretBulkInsert({
inputSecrets: inputSecrets.map((el) => { inputSecrets: inputSecrets.map((el) => {
const references = secretReferencesGroupByInputSecretKey[el.secretKey].nestedReferences; const references = secretReferencesGroupByInputSecretKey[el.secretKey]?.nestedReferences;
return { return {
version: 1, version: 1,
@@ -1372,7 +1373,7 @@ export const secretV2BridgeServiceFactory = ({
typeof el.secretValue !== "undefined" typeof el.secretValue !== "undefined"
? { ? {
encryptedValue: secretManagerEncryptor({ plainText: Buffer.from(el.secretValue) }).cipherTextBlob, encryptedValue: secretManagerEncryptor({ plainText: Buffer.from(el.secretValue) }).cipherTextBlob,
references: secretReferencesGroupByInputSecretKey[el.secretKey].nestedReferences references: secretReferencesGroupByInputSecretKey[el.secretKey]?.nestedReferences
} }
: {}; : {};