awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-05 02:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: personal secret support without read value permission

Browse Source
This commit is contained in:
Daniel Hougaard
2025-03-05 22:47:39 +04:00
parent 8c403780c2
commit 90cfc44592
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/secret-v2-bridge/secret-v2-bridge-service.ts
+5 -2
View File
@@ -950,6 +950,8 @@ export const secretV2BridgeServiceFactory = ({
); );
}) })
.map((secret) => { .map((secret) => {
const isPersonalSecret = secret.userId === actorId && secret.type === SecretType.Personal;
const secretValueHidden = const secretValueHidden =
!viewSecretValue || !viewSecretValue ||
!permission.can( !permission.can(
@@ -975,7 +977,7 @@ export const secretV2BridgeServiceFactory = ({
? secretManagerDecryptor({ cipherTextBlob: secret.encryptedComment }).toString() ? secretManagerDecryptor({ cipherTextBlob: secret.encryptedComment }).toString()
: "" : ""
}, },
secretValueHidden secretValueHidden && !isPersonalSecret
); );
}); });
@@ -1244,7 +1246,8 @@ export const secretV2BridgeServiceFactory = ({
secretName, secretName,
secretTags: (secret?.tags || []).map((el) => el.slug) secretTags: (secret?.tags || []).map((el) => el.slug)
}) })
) ) &&
secretType !== SecretType.Personal
) { ) {
throw new ForbiddenReadSecretError({ throw new ForbiddenReadSecretError({
message: `You do not have permission to view secret value on secret with name '${secretName}'` message: `You do not have permission to view secret value on secret with name '${secretName}'`