From 90f85152bc1862ebeac6a0ec51d2b018011ea4c9 Mon Sep 17 00:00:00 2001 From: Sheen Capadngan Date: Tue, 5 Nov 2024 22:08:16 +0800 Subject: [PATCH] misc: added configurable env for enabling/disabling encrypt --- .env.example | 2 ++ .../secret-rotation-queue/secret-rotation-queue.ts | 3 ++- backend/src/lib/config/env.ts | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.env.example b/.env.example index 8bcb4039d..9998769da 100644 --- a/.env.example +++ b/.env.example @@ -78,3 +78,5 @@ PLAIN_API_KEY= PLAIN_WISH_LABEL_IDS= SSL_CLIENT_CERTIFICATE_HEADER_KEY= + +ENABLE_MSSQL_SECRET_ROTATION_ENCRYPT= diff --git a/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue.ts b/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue.ts index d21f7674b..015cce0e5 100644 --- a/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue.ts +++ b/backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue.ts @@ -116,6 +116,7 @@ export const secretRotationQueueFactory = ({ queue.start(QueueName.SecretRotation, async (job) => { const { rotationId } = job.data; + const appCfg = getConfig(); logger.info(`secretRotationQueue.process: [rotationDocument=${rotationId}]`); const secretRotation = await secretRotationDAL.findById(rotationId); const rotationProvider = rotationTemplates.find(({ name }) => name === secretRotation?.provider); @@ -178,7 +179,7 @@ export const secretRotationQueueFactory = ({ const options = provider.template.client === TDbProviderClients.MsSqlServer ? ({ - encrypt: true, + encrypt: appCfg.ENABLE_MSSQL_SECRET_ROTATION_ENCRYPT, cryptoCredentialsDetails: ca ? { ca } : {} } as Record) : undefined; diff --git a/backend/src/lib/config/env.ts b/backend/src/lib/config/env.ts index 60f4b74a9..638f21e5d 100644 --- a/backend/src/lib/config/env.ts +++ b/backend/src/lib/config/env.ts @@ -162,7 +162,8 @@ const envSchema = z DISABLE_AUDIT_LOG_GENERATION: zodStrBool.default("false"), SSL_CLIENT_CERTIFICATE_HEADER_KEY: zpStr(z.string().optional()).default("x-ssl-client-cert"), WORKFLOW_SLACK_CLIENT_ID: zpStr(z.string().optional()), - WORKFLOW_SLACK_CLIENT_SECRET: zpStr(z.string().optional()) + WORKFLOW_SLACK_CLIENT_SECRET: zpStr(z.string().optional()), + ENABLE_MSSQL_SECRET_ROTATION_ENCRYPT: zodStrBool.default("true") }) .transform((data) => ({ ...data,