feat: enabled order by desc for audit log and added sort for couple of get queries

This commit is contained in:
Akhil Mohan
2024-02-02 20:56:42 +05:30
parent 72d46efba5
commit 937e48dbc5
4 changed files with 6 additions and 4 deletions
@@ -38,7 +38,8 @@ export const auditLogDALFactory = (db: TDbClient) => {
}) })
) )
.limit(limit) .limit(limit)
.offset(offset); .offset(offset)
.orderBy("createdAt", "desc");
if (startDate) { if (startDate) {
void sqlQuery.where("createdAt", ">=", startDate); void sqlQuery.where("createdAt", ">=", startDate);
} }
@@ -47,7 +47,7 @@ export const secretTagServiceFactory = ({ secretTagDAL, permissionService }: TSe
const { permission } = await permissionService.getProjectPermission(actor, actorId, projectId); const { permission } = await permissionService.getProjectPermission(actor, actorId, projectId);
ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.Tags); ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.Tags);
const tags = await secretTagDAL.find({ projectId }); const tags = await secretTagDAL.find({ projectId }, { sort: [["createdAt", "asc"]] });
return tags; return tags;
}; };
@@ -117,7 +117,7 @@ export const serviceTokenServiceFactory = ({
const { permission } = await permissionService.getProjectPermission(actor, actorId, projectId); const { permission } = await permissionService.getProjectPermission(actor, actorId, projectId);
ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.ServiceTokens); ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.ServiceTokens);
const tokens = await serviceTokenDAL.find({ projectId }); const tokens = await serviceTokenDAL.find({ projectId }, { sort: [["createdAt", "desc"]] });
return tokens; return tokens;
}; };
+2 -1
View File
@@ -80,7 +80,8 @@ export const webhookDALFactory = (db: TDbClient) => {
.select(db.ref("slug").withSchema(TableName.Environment).as("envSlug")) .select(db.ref("slug").withSchema(TableName.Environment).as("envSlug"))
.select(db.ref("id").withSchema(TableName.Environment).as("envId")) .select(db.ref("id").withSchema(TableName.Environment).as("envId"))
.select(db.ref("projectId").withSchema(TableName.Environment)) .select(db.ref("projectId").withSchema(TableName.Environment))
.select(selectAllTableCols(TableName.Webhook)); .select(selectAllTableCols(TableName.Webhook))
.orderBy(`${TableName.Webhook}.createdAt`, "asc");
return webhooks.map(({ envId, envSlug, envName, ...el }) => ({ return webhooks.map(({ envId, envSlug, envName, ...el }) => ({
...el, ...el,