awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 06:28:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

improvement: make limit conditional

Browse Source
This commit is contained in:
Scott Wilson
2024-09-12 16:19:22 -07:00
parent ed3bc8dd27
commit 93f27a7ee8
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/identity-project/identity-project-dal.ts
+4 -2
View File
@@ -131,8 +131,6 @@ export const identityProjectDALFactory = (db: TDbClient) => {
`${TableName.Identity}.id` `${TableName.Identity}.id`
) )
.where(`${TableName.IdentityProjectMembership}.projectId`, projectId) .where(`${TableName.IdentityProjectMembership}.projectId`, projectId)
.offset(filter.offset ?? 0)
.limit(filter.limit ?? 100)
.orderBy( .orderBy(
`${TableName.Identity}.${filter.orderBy ?? ProjectIdentityOrderBy.Name}`, `${TableName.Identity}.${filter.orderBy ?? ProjectIdentityOrderBy.Name}`,
filter.orderDirection ?? OrderByDirection.ASC filter.orderDirection ?? OrderByDirection.ASC
@@ -140,6 +138,10 @@ export const identityProjectDALFactory = (db: TDbClient) => {
.select(selectAllTableCols(TableName.Identity)) .select(selectAllTableCols(TableName.Identity))
.as(TableName.Identity); // required for subqueries .as(TableName.Identity); // required for subqueries
if (filter.limit) {
void fetchIdentitySubquery.offset(filter.offset ?? 0).limit(filter.limit);
}
const query = (tx || db.replicaNode())(TableName.IdentityProjectMembership) const query = (tx || db.replicaNode())(TableName.IdentityProjectMembership)
.where(`${TableName.IdentityProjectMembership}.projectId`, projectId) .where(`${TableName.IdentityProjectMembership}.projectId`, projectId)
.join(TableName.Project, `${TableName.IdentityProjectMembership}.projectId`, `${TableName.Project}.id`) .join(TableName.Project, `${TableName.IdentityProjectMembership}.projectId`, `${TableName.Project}.id`)