From 97e860cf212fbfc7ca574165f2efd9f5453829fd Mon Sep 17 00:00:00 2001 From: Meet Date: Thu, 3 Oct 2024 16:37:21 +0530 Subject: [PATCH] feat: add better error on invalid LDIF --- backend/src/ee/services/dynamic-secret/providers/ldap.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/backend/src/ee/services/dynamic-secret/providers/ldap.ts b/backend/src/ee/services/dynamic-secret/providers/ldap.ts index 9fcfb125d..aa0182c76 100644 --- a/backend/src/ee/services/dynamic-secret/providers/ldap.ts +++ b/backend/src/ee/services/dynamic-secret/providers/ldap.ts @@ -90,7 +90,13 @@ export const LdapProvider = (): TDynamicProviderFns => { }; const executeLdif = async (client: ldapjs.Client, ldif_file: string) => { - const parsedEntries: any = ldif.parse(ldif_file).entries as any[]; + let parsedEntries; + try { + parsedEntries = ldif.parse(ldif_file).entries as any[]; + } catch (err) { + throw new BadRequestError({ message: "Invalid LDIF, Please check LDIF entries section in the documentation." }); + } + const dnArray: string[] = []; for (const entry of parsedEntries) {