awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 19:28:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1520 from rhythmbhiwani/remove-nested-anchor-tags

Browse Source 
Changed <a> to <div> to avoid nested <a>
This commit is contained in:
Akhil Mohan
2024-03-04 11:58:32 +05:30
committed by GitHub
parent d3a6da187b 7a90fa472d
commit 9e38076d45
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/v2/Menu/Menu.tsx
+11 -11
View File
@@ -42,27 +42,27 @@ export const MenuItem = <T extends ElementType = "button">({
const iconRef = useRef(); const iconRef = useRef();
return ( return (
<a onMouseEnter={() => iconRef.current?.play()} onMouseLeave={() => iconRef.current?.stop()}> <div onMouseEnter={() => iconRef.current?.play()} onMouseLeave={() => iconRef.current?.stop()}>
<li <li
className={twMerge( className={twMerge(
"group px-1 py-2 mt-0.5 font-inter flex flex-col text-sm text-bunker-100 transition-all rounded cursor-pointer hover:bg-mineshaft-700 duration-50", "duration-50 group mt-0.5 flex cursor-pointer flex-col rounded px-1 py-2 font-inter text-sm text-bunker-100 transition-all hover:bg-mineshaft-700",
isSelected && "bg-mineshaft-600 hover:bg-mineshaft-600", isSelected && "bg-mineshaft-600 hover:bg-mineshaft-600",
isDisabled && "hover:bg-transparent cursor-not-allowed", isDisabled && "cursor-not-allowed hover:bg-transparent",
className className
)} )}
> >
<motion.span className="w-full flex flex-row items-center justify-start rounded-sm"> <motion.span className="flex w-full flex-row items-center justify-start rounded-sm">
<Item <Item
type="button" type="button"
role="menuitem" role="menuitem"
className="flex items-center relative" className="relative flex items-center"
ref={inputRef} ref={inputRef}
{...props} {...props}
> >
<div <div
className={`${ className={`${
isSelected ? "visisble" : "invisible" isSelected ? "visisble" : "invisible"
} -left-[0.28rem] absolute w-[0.07rem] rounded-md h-5 bg-primary`} } absolute -left-[0.28rem] h-5 w-[0.07rem] rounded-md bg-primary`}
/> />
{/* {icon && <span className="mr-3 ml-4 w-5 block group-hover:hidden">{icon}</span>} */} {/* {icon && <span className="mr-3 ml-4 w-5 block group-hover:hidden">{icon}</span>} */}
{icon && ( {icon && (
@@ -81,7 +81,7 @@ export const MenuItem = <T extends ElementType = "button">({
{description && <span className="mt-2 text-xs">{description}</span>} {description && <span className="mt-2 text-xs">{description}</span>}
</motion.span> </motion.span>
</li> </li>
</a> </div>
); );
}; };
@@ -103,16 +103,16 @@ export const SubMenuItem = <T extends ElementType = "button">({
<a onMouseEnter={() => iconRef.current?.play()} onMouseLeave={() => iconRef.current?.stop()}> <a onMouseEnter={() => iconRef.current?.play()} onMouseLeave={() => iconRef.current?.stop()}>
<li <li
className={twMerge( className={twMerge(
"group px-1 py-1 mt-0.5 font-inter flex flex-col text-sm text-mineshaft-300 hover:text-mineshaft-100 transition-all rounded cursor-pointer hover:bg-mineshaft-700 duration-50", "duration-50 group mt-0.5 flex cursor-pointer flex-col rounded px-1 py-1 font-inter text-sm text-mineshaft-300 transition-all hover:bg-mineshaft-700 hover:text-mineshaft-100",
isDisabled && "hover:bg-transparent cursor-not-allowed", isDisabled && "cursor-not-allowed hover:bg-transparent",
className className
)} )}
> >
<motion.span className="w-full flex flex-row items-center justify-start rounded-sm pl-6"> <motion.span className="flex w-full flex-row items-center justify-start rounded-sm pl-6">
<Item <Item
type="button" type="button"
role="menuitem" role="menuitem"
className="flex items-center relative" className="relative flex items-center"
ref={inputRef} ref={inputRef}
{...props} {...props}
> >