greptile review fixes

backend/src/server/routes/v1/secret-sharing-router.ts

@@ -156,7 +156,7 @@ export const registerSecretSharingRouter = async (server: FastifyZodProvider) =>
         expiresAt: z.string(),
         expiresAfterViews: z.number().min(1).optional(),
         accessType: z.nativeEnum(SecretSharingAccessType).default(SecretSharingAccessType.Organization),
-        emails: z.string().email().array().optional()
+        emails: z.string().email().array().max(100).optional()
       }),
       response: {
         200: z.object({

frontend/src/hooks/api/secretSharing/queries.ts

@@ -11,10 +11,13 @@ export const secretSharingKeys = {
   allSecretRequests: () => ["secretRequests"] as const,
   specificSecretRequests: ({ offset, limit }: { offset: number; limit: number }) =>
     [...secretSharingKeys.allSecretRequests(), { offset, limit }] as const,
-  getSecretById: (arg: { id: string; hashedHex: string | null; password?: string }) => [
+  getSecretById: (arg: {
-    "shared-secret",
+    id: string;
-    arg
+    hashedHex: string | null;
-  ],
+    password?: string;
+    email?: string;
+    token?: string;
+  }) => ["shared-secret", arg],
   getSecretRequestById: (arg: { id: string }) => ["secret-request", arg] as const
 };
 
@@ -83,7 +86,13 @@ export const useGetActiveSharedSecretById = ({
   token?: string;
 }) => {
   return useQuery({
-    queryKey: secretSharingKeys.getSecretById({ id: sharedSecretId, hashedHex, password }),
+    queryKey: secretSharingKeys.getSecretById({
+      id: sharedSecretId,
+      hashedHex,
+      password,
+      email,
+      token
+    }),
     queryFn: async () => {
       const { data } = await apiRequest.post<TViewSharedSecretResponse>(
         `/api/v1/secret-sharing/shared/public/${sharedSecretId}`,

frontend/src/pages/public/ShareSecretPage/components/ShareSecretForm.tsx

@@ -52,10 +52,15 @@ const schema = z.object({
     .refine(
       (val) => {
         if (!val) return true;
-        return val.split(",").every((email) => z.string().email().safeParse(email.trim()).success);
+        const emails = val
+          .split(",")
+          .map((email) => email.trim())
+          .filter((email) => email !== "");
+        if (emails.length > 100) return false;
+        return emails.every((email) => z.string().email().safeParse(email).success);
       },
       {
-        message: "Must be a comma-separated list of valid emails or empty."
+        message: "Must be a comma-separated list of valid emails (max 100) or empty."
       }
     )
 });
@@ -249,7 +254,7 @@ export const ShareSecretForm = ({
                       v ? SecretSharingAccessType.Organization : SecretSharingAccessType.Anyone
                     )
                   }
-                  id="delete-secrets"
+                  id="org-access-only"
                 >
                   Limit access to people within organization
                 </Switch>