awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 17:27:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix returning errors

Browse Source
This commit is contained in:
Fang-Pen Lin
2025-11-07 09:19:53 -08:00
parent bba265d21e
commit a0c0bd6a40
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/pki-acme/pki-acme-service.ts
+4 -4
View File
@@ -521,7 +521,7 @@ export const pkiAcmeServiceFactory = ({
const { csr } = payload; const { csr } = payload;
// TODO: validate the CSR and return badCSR error if it's invalid // TODO: validate the CSR and return badCSR error if it's invalid
// TODO: this should be the same transaction? // TODO: this should be the same transaction?
let error: Error | undefined; let errorToReturn: Error | undefined;
try { try {
const { certificate, certificateChain, certificateId } = const { certificate, certificateChain, certificateId } =
await certificateV3Service.signCertificateFromProfile({ await certificateV3Service.signCertificateFromProfile({
@@ -563,14 +563,14 @@ export const pkiAcmeServiceFactory = ({
// TODO: log the error // TODO: log the error
// TODO: audit log the error // TODO: audit log the error
if (error instanceof BadRequestError) { if (error instanceof BadRequestError) {
error = new AcmeBadCSRError({ detail: `Invalid CSR: ${error.message}` }); errorToReturn = new AcmeBadCSRError({ detail: `Invalid CSR: ${error.message}` });
} else { } else {
error = new AcmeServerInternalError({ detail: "Failed to sign certificate" }); errorToReturn = new AcmeServerInternalError({ detail: "Failed to sign certificate with internal error" });
} }
} }
return { return {
order: (await acmeOrderDAL.findByAccountAndOrderIdWithAuthorizations(accountId, orderId, tx))!, order: (await acmeOrderDAL.findByAccountAndOrderIdWithAuthorizations(accountId, orderId, tx))!,
error error: errorToReturn
}; };
}); });
if (error) { if (error) {