misc: added no access exemption

This commit is contained in:
Sheen Capadngan
2025-03-27 13:26:30 +08:00
parent 956d0f6c5d
commit a1318d54b1
2 changed files with 38 additions and 35 deletions
@@ -87,7 +87,7 @@ export const groupServiceFactory = ({
actorOrgId actorOrgId
); );
const isCustomRole = Boolean(customRole); const isCustomRole = Boolean(customRole);
if (role !== OrgMembershipRole.NoAccess) {
const permissionBoundary = validatePrivilegeChangeOperation( const permissionBoundary = validatePrivilegeChangeOperation(
membership.shouldUseNewPrivilegeSystem, membership.shouldUseNewPrivilegeSystem,
OrgPermissionGroupActions.GrantPrivileges, OrgPermissionGroupActions.GrantPrivileges,
@@ -106,6 +106,7 @@ export const groupServiceFactory = ({
), ),
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });
}
const group = await groupDAL.transaction(async (tx) => { const group = await groupDAL.transaction(async (tx) => {
const existingGroup = await groupDAL.findOne({ orgId: actorOrgId, name }, tx); const existingGroup = await groupDAL.findOne({ orgId: actorOrgId, name }, tx);
+2
View File
@@ -945,6 +945,7 @@ export const orgServiceFactory = ({
projectId projectId
); );
if (invitedRole !== ProjectMembershipRole.NoAccess) {
const permissionBoundary = validatePrivilegeChangeOperation( const permissionBoundary = validatePrivilegeChangeOperation(
membership.shouldUseNewPrivilegeSystem, membership.shouldUseNewPrivilegeSystem,
ProjectPermissionMemberActions.GrantPrivileges, ProjectPermissionMemberActions.GrantPrivileges,
@@ -964,6 +965,7 @@ export const orgServiceFactory = ({
details: { missingPermissions: permissionBoundary.missingPermissions } details: { missingPermissions: permissionBoundary.missingPermissions }
}); });
} }
}
const customProjectRoles = invitedProjectRoles.filter( const customProjectRoles = invitedProjectRoles.filter(
(role) => !Object.values(ProjectMembershipRole).includes(role as ProjectMembershipRole) (role) => !Object.values(ProjectMembershipRole).includes(role as ProjectMembershipRole)