Merge pull request #4563 from Infisical/correct-app-connection-org-permission

fix(app-connections): correct app connection service org permission check argument order
This commit is contained in:
Scott Wilson
2025-09-22 09:02:29 -07:00
committed by GitHub

View File

@@ -266,9 +266,9 @@ export const appConnectionServiceFactory = ({
const { permission } = await permissionService.getOrgPermission( const { permission } = await permissionService.getOrgPermission(
actor.type, actor.type,
actor.id, actor.id,
actor.orgId, appConnection.orgId,
actor.authMethod, actor.authMethod,
appConnection.orgId actor.orgId
); );
ForbiddenError.from(permission).throwUnlessCan( ForbiddenError.from(permission).throwUnlessCan(
@@ -316,9 +316,9 @@ export const appConnectionServiceFactory = ({
const { permission } = await permissionService.getOrgPermission( const { permission } = await permissionService.getOrgPermission(
actor.type, actor.type,
actor.id, actor.id,
actor.orgId, appConnection.orgId,
actor.authMethod, actor.authMethod,
appConnection.orgId actor.orgId
); );
ForbiddenError.from(permission).throwUnlessCan( ForbiddenError.from(permission).throwUnlessCan(
@@ -475,9 +475,9 @@ export const appConnectionServiceFactory = ({
const { permission: orgPermission } = await permissionService.getOrgPermission( const { permission: orgPermission } = await permissionService.getOrgPermission(
actor.type, actor.type,
actor.id, actor.id,
actor.orgId, appConnection.orgId,
actor.authMethod, actor.authMethod,
appConnection.orgId actor.orgId
); );
if (appConnection.projectId) { if (appConnection.projectId) {
@@ -633,9 +633,9 @@ export const appConnectionServiceFactory = ({
const { permission } = await permissionService.getOrgPermission( const { permission } = await permissionService.getOrgPermission(
actor.type, actor.type,
actor.id, actor.id,
actor.orgId, appConnection.orgId,
actor.authMethod, actor.authMethod,
appConnection.orgId actor.orgId
); );
ForbiddenError.from(permission).throwUnlessCan( ForbiddenError.from(permission).throwUnlessCan(
@@ -803,9 +803,9 @@ export const appConnectionServiceFactory = ({
const { permission } = await permissionService.getOrgPermission( const { permission } = await permissionService.getOrgPermission(
actor.type, actor.type,
actor.id, actor.id,
actor.orgId, appConnection.orgId,
actor.authMethod, actor.authMethod,
appConnection.orgId actor.orgId
); );
ForbiddenError.from(permission).throwUnlessCan( ForbiddenError.from(permission).throwUnlessCan(