awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 15:27:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

improvement: move client instantation to try/catch for sql connection validation for error propogation

Browse Source
This commit is contained in:
Scott Wilson
2025-04-21 13:49:09 -07:00
parent 35f0e8f49a
commit a4eb2e77c2
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/app-connection/shared/sql/sql-connection-fns.ts
+7 -5
View File
@@ -77,20 +77,22 @@ export const getSqlConnectionClient = async (appConnection: Pick<TSqlConnection,
export const validateSqlConnectionCredentials = async (config: TSqlConnectionConfig) => { export const validateSqlConnectionCredentials = async (config: TSqlConnectionConfig) => {
const { credentials, app } = config; const { credentials, app } = config;
const client = await getSqlConnectionClient({ app, credentials }); let client: Knex | undefined;
try { try {
client = await getSqlConnectionClient({ app, credentials });
await client.raw(`Select 1`); await client.raw(`Select 1`);
return credentials; return credentials;
} catch (error) { } catch (error) {
throw new BadRequestError({ throw new BadRequestError({
message: message: `Unable to validate connection: ${
(error as Error)?.message?.replaceAll(credentials.password, "********************") ?? (error as Error)?.message?.replaceAll(credentials.password, "********************") ?? "verify credentials"
"Unable to validate connection: verify credentials" }`
}); });
} finally { } finally {
await client.destroy(); await client?.destroy();
} }
}; };