awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4562 from Infisical/fix-secret-value-key-resolution-dashboard

Browse Source 
fix(dashboard): correct secret key resolution when retrieving dashboard value
This commit is contained in:
Scott Wilson
2025-09-19 13:21:55 -07:00
committed by GitHub
parent 1ed87947f8 19f392f889
commit a78e593ea4
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
backend/src/server/routes/v1/dashboard-router.ts
View File

@@ -1457,6 +1457,7 @@ export const registerDashboardRouter = async (server: FastifyZodProvider) => {
handler: async (req) => { handler: async (req) => {
const { secretPath, projectId, environment, secretKey, isOverride } = req.query; const { secretPath, projectId, environment, secretKey, isOverride } = req.query;
// TODO (scott): just get the secret instead of searching for it in list
const { secrets } = await server.services.secret.getSecretsRaw({ const { secrets } = await server.services.secret.getSecretsRaw({
actorId: req.permission.id, actorId: req.permission.id,
actor: req.permission.type, actor: req.permission.type,
@@ -1473,7 +1474,9 @@ export const registerDashboardRouter = async (server: FastifyZodProvider) => {
}); });
if (isOverride) { if (isOverride) {
const personalSecret = secrets.find((secret) => secret.type === SecretType.Personal); const personalSecret = secrets.find(
(secret) => secret.type === SecretType.Personal && secret.secretKey === secretKey
);
if (!personalSecret) if (!personalSecret)
throw new BadRequestError({ throw new BadRequestError({
@@ -1486,7 +1489,9 @@ export const registerDashboardRouter = async (server: FastifyZodProvider) => {
}; };
} }
const sharedSecret = secrets.find((secret) => secret.type === SecretType.Shared); const sharedSecret = secrets.find(
(secret) => secret.type === SecretType.Shared && secret.secretKey === secretKey
);
if (!sharedSecret) if (!sharedSecret)
throw new BadRequestError({ throw new BadRequestError({