awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 19:28:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: simplified delete query for secret folder version

Browse Source
This commit is contained in:
Sheen Capadngan
2024-06-03 12:49:40 +08:00
parent b8e9417466
commit ab093dfc85
1 changed files with 20 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/secret-folder/secret-folder-version-dal.ts
+13 -18
View File
@@ -62,32 +62,27 @@ export const secretFolderVersionDALFactory = (db: TDbClient) => {
} }
}; };
const pruneExcessVersions = async (tx?: Knex) => { const pruneExcessVersions = async () => {
try { try {
const rankedFolderVersions = (tx || db)(TableName.SecretFolderVersion) await secretFolderVerOrm.transaction((txn) => {
return txn(TableName.SecretFolderVersion)
.with("folder_cte", (qb) => {
void qb
.from(TableName.SecretFolderVersion)
.select( .select(
"id", "id",
"folderId", "folderId",
(tx || db).raw( txn.raw(
`ROW_NUMBER() OVER (PARTITION BY ${TableName.SecretFolderVersion}."folderId" ORDER BY ${TableName.SecretFolderVersion}."createdAt" DESC) AS row_num` `ROW_NUMBER() OVER (PARTITION BY ${TableName.SecretFolderVersion}."folderId" ORDER BY ${TableName.SecretFolderVersion}."createdAt" DESC) AS row_num`
) )
) );
.as("ranked_folder_versions"); })
const folderLimits = (tx || db)(TableName.SecretFolderVersion)
.join(TableName.Environment, `${TableName.Environment}.id`, `${TableName.SecretFolderVersion}.envId`) .join(TableName.Environment, `${TableName.Environment}.id`, `${TableName.SecretFolderVersion}.envId`)
.join(TableName.Project, `${TableName.Project}.id`, `${TableName.Environment}.projectId`) .join(TableName.Project, `${TableName.Project}.id`, `${TableName.Environment}.projectId`)
.groupBy(`${TableName.SecretFolderVersion}.folderId`, `${TableName.Project}.pitVersionLimit`) .join("folder_cte", "folder_cte.id", `${TableName.SecretFolderVersion}.id`)
.select("folderId", "pitVersionLimit") .whereRaw(`folder_cte.row_num > ${TableName.Project}."pitVersionLimit"`)
.as("folder_limits"); .delete();
});
const versionsToKeep = (tx || db)(rankedFolderVersions)
.select("id")
.from(rankedFolderVersions)
.join(folderLimits, "folder_limits.folderId", "ranked_folder_versions.folderId")
.whereRaw(`ranked_folder_versions.row_num <= folder_limits."pitVersionLimit"`);
await (tx || db)(TableName.SecretFolderVersion).whereNotIn("id", versionsToKeep).delete();
} catch (error) { } catch (error) {
throw new DatabaseError({ throw new DatabaseError({
error, error,