fix: review comments

This commit is contained in:
Piyush Gupta
2025-10-15 21:27:44 +05:30
parent 4d19b9faab
commit ad6b4c716c
7 changed files with 72 additions and 36 deletions
@@ -17,7 +17,7 @@ export const SecretSyncModalHeader = ({ destination, isConfigured }: Props) => {
<img
alt={`${destinationDetails.name} logo`}
src={`/images/integrations/${destinationDetails.image}`}
className={`h-12 w-12 rounded-md bg-bunker-500 p-2 ${destinationDetails.imageClassName}`}
className="h-12 w-12 rounded-md bg-bunker-500 object-contain p-2"
/>
<div>
<div className="flex items-center text-mineshaft-300">
+1 -3
View File
@@ -63,7 +63,6 @@ export const APP_CONNECTION_MAP: Record<
size?: number;
icon?: IconDefinition;
enterprise?: boolean;
imageClassName?: string;
}
> = {
[AppConnection.AWS]: { name: "AWS", image: "Amazon Web Services.png" },
@@ -126,8 +125,7 @@ export const APP_CONNECTION_MAP: Record<
[AppConnection.Redis]: { name: "Redis", image: "Redis.png" },
[AppConnection.LaravelForge]: {
name: "Laravel Forge",
image: "Laravel Forge.png",
imageClassName: "object-contain"
image: "Laravel Forge.png"
}
};
+2 -6
View File
@@ -8,10 +8,7 @@ import { GcpSyncScope } from "@app/hooks/api/secretSyncs/types/gcp-sync";
import { HumanitecSyncScope } from "@app/hooks/api/secretSyncs/types/humanitec-sync";
import { RenderSyncScope } from "@app/hooks/api/secretSyncs/types/render-sync";
export const SECRET_SYNC_MAP: Record<
SecretSync,
{ name: string; image: string; imageClassName?: string }
> = {
export const SECRET_SYNC_MAP: Record<SecretSync, { name: string; image: string }> = {
[SecretSync.AWSParameterStore]: { name: "AWS Parameter Store", image: "Amazon Web Services.png" },
[SecretSync.AWSSecretsManager]: { name: "AWS Secrets Manager", image: "Amazon Web Services.png" },
[SecretSync.GitHub]: { name: "GitHub", image: "GitHub.png" },
@@ -119,8 +116,7 @@ export const SECRET_SYNC_MAP: Record<
},
[SecretSync.LaravelForge]: {
name: "Laravel Forge",
image: "Laravel Forge.png",
imageClassName: "object-contain"
image: "Laravel Forge.png"
}
};
@@ -19,7 +19,7 @@ export const AppConnectionHeader = ({ app, isConnected, onBack }: Props) => {
<img
alt={`${appDetails.name} logo`}
src={`/images/integrations/${appDetails.image}`}
className={`h-12 w-12 rounded-md bg-bunker-500 p-2 ${appDetails.imageClassName}`}
className="h-12 w-12 rounded-md bg-bunker-500 object-contain p-2"
/>
{appDetails.icon && (
<FontAwesomeIcon