awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 04:27:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor improvements on reminders migration

Browse Source
This commit is contained in:
Carlos Monastyrski
2025-07-25 13:35:06 -03:00
parent cd71848800
commit af32948a05
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/db/migrations/20250725144940_fix-secret-reminders-migration.ts
+6 -4
View File
@@ -22,10 +22,12 @@ export async function up(knex: Knex): Promise<void> {
}) })
.whereIn([`${TableName.SecretVersionV2}.secretId`, `${TableName.SecretVersionV2}.version`], (qb) => { .whereIn([`${TableName.SecretVersionV2}.secretId`, `${TableName.SecretVersionV2}.version`], (qb) => {
void qb void qb
.select(["secretId", knex.raw("MAX(version) as version")]) .select(["v2.secretId", knex.raw("MIN(v2.version) as version")])
.from(`${TableName.SecretVersionV2} as v2`) .from(`${TableName.SecretVersionV2} as v2`)
.innerJoin(`${TableName.SecretV2} as s2`, "v2.secretId", "s2.id")
.whereRaw(`v2."reminderRepeatDays" = s2."reminderRepeatDays"`)
.whereNotNull("v2.reminderRepeatDays") .whereNotNull("v2.reminderRepeatDays")
.whereRaw(`"v2"."reminderRepeatDays" > 0`) .whereRaw(`v2."reminderRepeatDays" > 0`)
.groupBy("v2.secretId"); .groupBy("v2.secretId");
}) })
// Add LEFT JOIN with Reminder table to check for existing reminders // Add LEFT JOIN with Reminder table to check for existing reminders
@@ -56,7 +58,7 @@ export async function up(knex: Knex): Promise<void> {
}); });
}); });
const commitBatches = chunkArray(reminderInserts, 9000); const commitBatches = chunkArray(reminderInserts, 2000);
for (const commitBatch of commitBatches) { for (const commitBatch of commitBatches) {
const insertedReminders = (await knex const insertedReminders = (await knex
.batchInsert(TableName.Reminder, commitBatch) .batchInsert(TableName.Reminder, commitBatch)
@@ -79,7 +81,7 @@ export async function up(knex: Knex): Promise<void> {
userId: recipient.userId userId: recipient.userId
})); }));
const filteredRecipients = reminderRecipients.filter((recipient) => !!recipient.reminderId); const filteredRecipients = reminderRecipients.filter((recipient) => Boolean(recipient.reminderId));
await knex.batchInsert(TableName.ReminderRecipient, filteredRecipients); await knex.batchInsert(TableName.ReminderRecipient, filteredRecipients);
} }
logger.info(`Successfully migrated ${reminderInserts.length} secret reminders`); logger.info(`Successfully migrated ${reminderInserts.length} secret reminders`);