From afa2f383c529edb8d053ec20f0128732d1b538d2 Mon Sep 17 00:00:00 2001
From: Scott Wilson <scottraywilson@gmail.com>
Date: Mon, 2 Dec 2024 09:35:03 -0800
Subject: [PATCH] improvement: address feedback

---
 .../ApprovalPolicyList/ApprovalPolicyList.tsx |  2 --
 .../components/ApprovalPolicyRow.tsx          | 29 +++++--------------
 2 files changed, 8 insertions(+), 23 deletions(-)

diff --git a/frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/ApprovalPolicyList.tsx b/frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/ApprovalPolicyList.tsx
index de8daec9e..d2a4e3788 100644
--- a/frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/ApprovalPolicyList.tsx
+++ b/frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/ApprovalPolicyList.tsx
@@ -256,9 +256,7 @@ export const ApprovalPolicyList = ({ workspaceId }: IProps) => {
             {!!currentWorkspace &&
               filteredPolicies?.map((policy) => (
                 <ApprovalPolicyRow
-                  // projectSlug={currentWorkspace.slug}
                   policy={policy}
-                  // workspaceId={workspaceId}
                   key={policy.id}
                   members={members}
                   groups={groups}
diff --git a/frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/components/ApprovalPolicyRow.tsx b/frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/components/ApprovalPolicyRow.tsx
index 5b9a882cd..865e92994 100644
--- a/frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/components/ApprovalPolicyRow.tsx
+++ b/frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/components/ApprovalPolicyRow.tsx
@@ -41,8 +41,6 @@ type Props = {
   policy: IPolicy;
   members?: TWorkspaceUser[];
   groups?: TGroupMembership[];
-  // projectSlug: string;
-  // workspaceId: string;
   onEdit: () => void;
   onDelete: () => void;
 };
@@ -51,26 +49,9 @@ export const ApprovalPolicyRow = ({
   policy,
   members = [],
   groups = [],
-  // projectSlug,
-  // workspaceId,
   onEdit,
   onDelete
 }: Props) => {
-  // TODO(scott): add back to enable editing from modal? edit modal for policy is fine for now
-  // const [selectedApprovers, setSelectedApprovers] = useState<Approver[]>(
-  //   policy.approvers?.filter((approver) => approver.type === ApproverType.User) || []
-  // );
-  // const [selectedGroupApprovers, setSelectedGroupApprovers] = useState<Approver[]>(
-  //   policy.approvers?.filter((approver) => approver.type === ApproverType.Group) || []
-  // );
-  // const { mutate: updateAccessApprovalPolicy, isLoading: isAccessApprovalPolicyLoading } =
-  //   useUpdateAccessApprovalPolicy();
-  // const { mutate: updateSecretApprovalPolicy, isLoading: isSecretApprovalPolicyLoading } =
-  //   useUpdateSecretApprovalPolicy();
-  // const isLoading = isAccessApprovalPolicyLoading || isSecretApprovalPolicyLoading;
-  //
-  // const { permission } = useProjectPermission();
-
   const labels = useMemo(() => {
     const usersInPolicy = policy.approvers
       ?.filter((approver) => approver.type === ApproverType.User)
@@ -106,12 +87,18 @@ export const ApprovalPolicyRow = ({
       <Td>{policy.environment.slug}</Td>
       <Td>{policy.secretPath || "*"}</Td>
       <Td className="max-w-0">
-        <Tooltip content={labels.members ?? "No users are assigned as approvers for this policy"}>
+        <Tooltip
+          side="left"
+          content={labels.members ?? "No users are assigned as approvers for this policy"}
+        >
           <p className="truncate">{labels.members ?? "-"}</p>
         </Tooltip>
       </Td>
       <Td className="max-w-0">
-        <Tooltip content={labels.groups ?? "No groups are assigned as approvers for this policy"}>
+        <Tooltip
+          side="left"
+          content={labels.groups ?? "No groups are assigned as approvers for this policy"}
+        >
           <p className="truncate">{labels.groups ?? "-"}</p>
         </Tooltip>
       </Td>