improvements: address coderabbit

This commit is contained in:
Scott Wilson
2025-04-04 18:08:07 -07:00
parent c2f2dc1e72
commit b0b255461d
2 changed files with 5 additions and 6 deletions
@@ -96,7 +96,7 @@ export const MsSqlConnectionForm = ({ appConnection, onSubmit }: Props) => {
render={({ field: { value, onChange }, fieldState: { error } }) => ( render={({ field: { value, onChange }, fieldState: { error } }) => (
<FormControl <FormControl
tooltipText={`The method you would like to use to connect with ${ tooltipText={`The method you would like to use to connect with ${
APP_CONNECTION_MAP[AppConnection.Postgres].name APP_CONNECTION_MAP[AppConnection.MsSql].name
}. This field cannot be changed after creation.`} }. This field cannot be changed after creation.`}
errorText={error?.message} errorText={error?.message}
isError={Boolean(error?.message)} isError={Boolean(error?.message)}
@@ -133,7 +133,7 @@ export const SqlConnectionFields = ({
<FormControl isError={Boolean(error?.message)} errorText={error?.message}> <FormControl isError={Boolean(error?.message)} errorText={error?.message}>
<Switch <Switch
className="bg-mineshaft-400/50 shadow-inner data-[state=checked]:bg-green/80" className="bg-mineshaft-400/50 shadow-inner data-[state=checked]:bg-green/80"
id="platform-managed" id="ssl-enabled"
thumbClassName="bg-mineshaft-800" thumbClassName="bg-mineshaft-800"
isChecked={value} isChecked={value}
onCheckedChange={onChange} onCheckedChange={onChange}
@@ -144,7 +144,6 @@ export const SqlConnectionFields = ({
</FormControl> </FormControl>
)} )}
/> />
<Controller <Controller
name="credentials.sslCertificate" name="credentials.sslCertificate"
control={control} control={control}
@@ -175,7 +174,7 @@ export const SqlConnectionFields = ({
> >
<Switch <Switch
className="bg-mineshaft-400/50 shadow-inner data-[state=checked]:bg-green/80" className="bg-mineshaft-400/50 shadow-inner data-[state=checked]:bg-green/80"
id="platform-managed" id="ssl-reject-unauthorized"
thumbClassName="bg-mineshaft-800" thumbClassName="bg-mineshaft-800"
isChecked={sslEnabled ? value : false} isChecked={sslEnabled ? value : false}
onCheckedChange={onChange} onCheckedChange={onChange}
@@ -187,8 +186,8 @@ export const SqlConnectionFields = ({
className="max-w-md" className="max-w-md"
content={ content={
<p> <p>
If enabled, Infisical will only connect to servers that have valid, If enabled, Infisical will only connect to the server if it has a valid,
trusted SSL certificates. trusted SSL certificate.
</p> </p>
} }
> >