requested changes

This commit is contained in:
Daniel Hougaard
2025-09-24 02:00:27 +04:00
parent 869d8ca47f
commit b1d73013b7
8 changed files with 54 additions and 36 deletions
@@ -53,7 +53,7 @@ export const RedisCredentialsRotationParametersFields = () => {
isError={Boolean(error)}
errorText={error?.message}
>
<Input {...field} placeholder="~* +@all" />
<Input {...field} placeholder="~* +@read @write" />
</FormControl>
)}
/>
@@ -10,7 +10,7 @@ export const RedisCredentialsRotationSchema = z
type: z.literal(SecretRotation.RedisCredentials),
parameters: z.object({
passwordRequirements: PasswordRequirementsSchema.optional(),
permissionScope: z.string().optional()
permissionScope: z.string().trim().min(1, "Permission scope is required")
}),
secretsMapping: z.object({
username: z.string().trim().min(1, "Username required"),
@@ -10,7 +10,7 @@ export type TRedisCredentialsRotation = TSecretRotationV2Base & {
type: SecretRotation.RedisCredentials;
parameters: {
passwordRequirements?: TPasswordRequirements;
permissionScope?: string;
permissionScope: string;
};
secretsMapping: {
username: string;
@@ -323,6 +323,8 @@ const UpdateForm = ({ appConnection, onComplete }: UpdateFormProps) => {
return <DigitalOceanConnectionForm onSubmit={onSubmit} appConnection={appConnection} />;
case AppConnection.Okta:
return <OktaConnectionForm onSubmit={onSubmit} appConnection={appConnection} />;
case AppConnection.Redis:
return <RedisConnectionForm onSubmit={onSubmit} appConnection={appConnection} />;
default:
throw new Error(`Unhandled App ${(appConnection as TAppConnection).app}`);
}