From b329b5aa4be10c4f659370b69273c4d6ebf4ebfd Mon Sep 17 00:00:00 2001
From: Scott Wilson <scottraywilson@gmail.com>
Date: Thu, 24 Apr 2025 19:35:56 -0700
Subject: [PATCH] improvements: address feedback

---
 backend/src/services/app-connection/ldap/ldap-connection-fns.ts | 1 +
 .../components/AppConnectionForm/AppConnectionForm.tsx          | 2 +-
 .../{LdapConnectionFields.tsx => LdapConnectionForm.tsx}        | 0
 3 files changed, 2 insertions(+), 1 deletion(-)
 rename frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/{LdapConnectionFields.tsx => LdapConnectionForm.tsx} (100%)

diff --git a/backend/src/services/app-connection/ldap/ldap-connection-fns.ts b/backend/src/services/app-connection/ldap/ldap-connection-fns.ts
index 225855768..03005c7d7 100644
--- a/backend/src/services/app-connection/ldap/ldap-connection-fns.ts
+++ b/backend/src/services/app-connection/ldap/ldap-connection-fns.ts
@@ -44,6 +44,7 @@ export const getLdapConnectionClient = async ({
 
     client.on("error", (err: Error) => {
       logger.error(err, "LDAP Error");
+      client.destroy();
       reject(new Error(`Provider Error - ${err.message}`));
     });
 
diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AppConnectionForm.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AppConnectionForm.tsx
index 7570eaa14..0d2ad54e9 100644
--- a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AppConnectionForm.tsx
+++ b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AppConnectionForm.tsx
@@ -18,7 +18,7 @@ import { DatabricksConnectionForm } from "./DatabricksConnectionForm";
 import { GcpConnectionForm } from "./GcpConnectionForm";
 import { GitHubConnectionForm } from "./GitHubConnectionForm";
 import { HumanitecConnectionForm } from "./HumanitecConnectionForm";
-import { LdapConnectionForm } from "./LdapConnectionFields";
+import { LdapConnectionForm } from "./LdapConnectionForm";
 import { MsSqlConnectionForm } from "./MsSqlConnectionForm";
 import { PostgresConnectionForm } from "./PostgresConnectionForm";
 import { TerraformCloudConnectionForm } from "./TerraformCloudConnectionForm";
diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/LdapConnectionFields.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/LdapConnectionForm.tsx
similarity index 100%
rename from frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/LdapConnectionFields.tsx
rename to frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/LdapConnectionForm.tsx