From b4e16fa1f4dc5fb449b59d1c8b65a04a3cc67ac9 Mon Sep 17 00:00:00 2001 From: Fang-Pen Lin Date: Fri, 21 Nov 2025 10:19:26 -0800 Subject: [PATCH] Fix insert and del --- .../dns-made-easy-connection-router.ts | 1 - .../acme/dns-providers/dns-made-easy.ts | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/backend/src/server/routes/v1/app-connection-routers/dns-made-easy-connection-router.ts b/backend/src/server/routes/v1/app-connection-routers/dns-made-easy-connection-router.ts index 398bd860e..e1e0b2860 100644 --- a/backend/src/server/routes/v1/app-connection-routers/dns-made-easy-connection-router.ts +++ b/backend/src/server/routes/v1/app-connection-routers/dns-made-easy-connection-router.ts @@ -44,7 +44,6 @@ export const registerDNSMadeEasyConnectionRouter = async (server: FastifyZodProv onRequest: verifyAuth([AuthMode.JWT]), handler: async (req) => { const { connectionId } = req.params; - const zones = await server.services.appConnection.dnsMadeEasy.listZones(connectionId, req.permission); return zones; } diff --git a/backend/src/services/certificate-authority/acme/dns-providers/dns-made-easy.ts b/backend/src/services/certificate-authority/acme/dns-providers/dns-made-easy.ts index 899f4aaf1..b3278e5d3 100644 --- a/backend/src/services/certificate-authority/acme/dns-providers/dns-made-easy.ts +++ b/backend/src/services/certificate-authority/acme/dns-providers/dns-made-easy.ts @@ -5,6 +5,7 @@ import { request } from "@app/lib/config/request"; import { crypto } from "@app/lib/crypto/cryptography"; import { TDNSMadeEasyConnection } from "@app/services/app-connection/dns-made-easy/dns-made-easy-connection-types"; import { IntegrationUrls } from "@app/services/integration-auth/integration-list"; +import { logger } from "@app/lib/logger"; const getDNSMadeEasyUrl = (path: string) => { const appCfg = getConfig(); @@ -100,7 +101,7 @@ export const dnsMadeEasyDeleteTxtRecord = async ( if (Array.isArray(dnsRecords) && dnsRecords.length > 0) { const recordToDelete = dnsRecords.find( - (record) => record.type === "TXT" && record.name === domain && record.value === value + (record) => record.type === "TXT" && record.name === domain && JSON.parse(record.value) === value ); if (recordToDelete) { @@ -113,6 +114,8 @@ export const dnsMadeEasyDeleteTxtRecord = async ( } } ); + } else { + logger.warn({ domain, value }, `Record to delete not found for domain: ${domain} and value: ${value}`); } } } catch (error) {