From b50a022d11824ef0b6be58192d5dcc6bbd8d49b8 Mon Sep 17 00:00:00 2001
From: x <x032205@gmail.com>
Date: Mon, 28 Apr 2025 13:28:47 -0400
Subject: [PATCH] PKCE check logic fix

---
 backend/src/ee/services/oidc/oidc-config-service.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/backend/src/ee/services/oidc/oidc-config-service.ts b/backend/src/ee/services/oidc/oidc-config-service.ts
index ce702fc95..27eeef9eb 100644
--- a/backend/src/ee/services/oidc/oidc-config-service.ts
+++ b/backend/src/ee/services/oidc/oidc-config-service.ts
@@ -687,8 +687,8 @@ export const oidcConfigServiceFactory = ({
 
     // Check if the OIDC provider supports PKCE
     const codeChallengeMethods = client.issuer.metadata.code_challenge_methods_supported;
-    const supportsPKCE =
-      !codeChallengeMethods || (Array.isArray(codeChallengeMethods) && codeChallengeMethods.includes("S256"));
+    // If codeChallengeMethods is undefined or includes "S256", then the provider supports PKCE
+    const supportsPKCE = Array.isArray(codeChallengeMethods) && codeChallengeMethods.includes("S256");
 
     const strategy = new OpenIdStrategy(
       {