improvements: address feedback

This commit is contained in:
Scott Wilson
2025-06-30 18:32:36 -07:00
parent 20366a8c07
commit b5801af9a8
2 changed files with 4 additions and 4 deletions
@@ -103,7 +103,7 @@ export const SecretApprovalRequestAction = ({
if (!hasMerged && status === "open") { if (!hasMerged && status === "open") {
return ( return (
<div className="flex w-full flex-col items-start justify-between py-4 text-mineshaft-100 transition-all"> <div className="flex w-full flex-col items-start justify-between py-4 text-mineshaft-100 transition-all">
<div className="flex w-full items-center justify-between"> <div className="flex w-full flex-col justify-between xl:flex-row xl:items-center">
<div className="mr-auto flex items-center space-x-4 px-4"> <div className="mr-auto flex items-center space-x-4 px-4">
<div <div
className={`flex items-center justify-center rounded-full ${isMergable ? "h-8 w-8 bg-green" : "h-10 w-10 bg-red-600"}`} className={`flex items-center justify-center rounded-full ${isMergable ? "h-8 w-8 bg-green" : "h-10 w-10 bg-red-600"}`}
@@ -126,7 +126,7 @@ export const SecretApprovalRequestAction = ({
)} )}
</span> </span>
</div> </div>
<div className="flex items-center justify-end space-x-2 px-4"> <div className="mt-4 flex items-center justify-end space-x-2 px-4 xl:mt-0">
{canApprove || isSoftEnforcement ? ( {canApprove || isSoftEnforcement ? (
<div className="flex items-center space-x-4"> <div className="flex items-center space-x-4">
<Button <Button
@@ -224,8 +224,8 @@ export const SecretApprovalRequestChanges = ({
const hasMerged = secretApprovalRequestDetails?.hasMerged; const hasMerged = secretApprovalRequestDetails?.hasMerged;
return ( return (
<div className="flex space-x-6"> <div className="flex flex-col space-x-6 lg:flex-row">
<div className="max-w-[calc(100%-17rem)] flex-1"> <div className="flex-1 lg:max-w-[calc(100%-17rem)]">
<div className="sticky top-0 z-20 flex items-center space-x-4 bg-bunker-800 pb-6 pt-2"> <div className="sticky top-0 z-20 flex items-center space-x-4 bg-bunker-800 pb-6 pt-2">
<IconButton variant="outline_bg" ariaLabel="go-back" onClick={onGoBack}> <IconButton variant="outline_bg" ariaLabel="go-back" onClick={onGoBack}>
<FontAwesomeIcon icon={faArrowLeft} /> <FontAwesomeIcon icon={faArrowLeft} />