From b9c4407507739489505d96b8100e8ac500fc0b74 Mon Sep 17 00:00:00 2001
From: Scott Wilson <scottraywilson@gmail.com>
Date: Thu, 6 Feb 2025 10:12:51 -0800
Subject: [PATCH] fix: skip empty values for create

---
 .../aws-secrets-manager-sync-fns.ts                    | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/backend/src/services/secret-sync/aws-secrets-manager/aws-secrets-manager-sync-fns.ts b/backend/src/services/secret-sync/aws-secrets-manager/aws-secrets-manager-sync-fns.ts
index f2521093d..545e4d762 100644
--- a/backend/src/services/secret-sync/aws-secrets-manager/aws-secrets-manager-sync-fns.ts
+++ b/backend/src/services/secret-sync/aws-secrets-manager/aws-secrets-manager-sync-fns.ts
@@ -203,9 +203,15 @@ export const AwsSecretsManagerSyncFns = {
       for await (const entry of Object.entries(secretMap)) {
         const [key, { value }] = entry;
 
+        // skip secrets that don't have a value set
+        if (!value) {
+          // eslint-disable-next-line no-continue
+          continue;
+        }
+
         if (awsSecretsRecord[key]) {
-          // skip secrets that haven't changed or don't have a value set
-          if (!value || awsValuesRecord[key]?.SecretString === value) {
+          // skip secrets that haven't changed
+          if (awsValuesRecord[key]?.SecretString === value) {
             // eslint-disable-next-line no-continue
             continue;
           }