From bb75ea550a0d6e7ce0b1d912993ec305a914f3ba Mon Sep 17 00:00:00 2001 From: Maidul Islam Date: Tue, 12 Dec 2023 22:17:46 -0500 Subject: [PATCH] prevent access token ttl=0 --- backend/src/validation/auth.ts | 4 +++- .../components/IdentitySection/IdentityUniversalAuthForm.tsx | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/backend/src/validation/auth.ts b/backend/src/validation/auth.ts index e723ba7d9..12121c61f 100644 --- a/backend/src/validation/auth.ts +++ b/backend/src/validation/auth.ts @@ -116,7 +116,9 @@ export const AddUniversalAuthToIdentityV1 = z.object({ .array() .min(1) .default([{ ipAddress: "0.0.0.0/0" }]), - accessTokenTTL: z.number().int().min(0).default(7200), + accessTokenTTL: z.number().int().min(1).refine(value => value !== 0, { + message: "accessTokenTTL must have a non zero number", + }).default(2592000), accessTokenMaxTTL: z.number().int().refine(value => value !== 0, { message: "accessTokenMaxTTL must have a non zero number", }).default(2592000), // 30 days diff --git a/frontend/src/views/Org/MembersPage/components/OrgIdentityTab/components/IdentitySection/IdentityUniversalAuthForm.tsx b/frontend/src/views/Org/MembersPage/components/OrgIdentityTab/components/IdentitySection/IdentityUniversalAuthForm.tsx index 6d327f9d4..99e5b4fea 100644 --- a/frontend/src/views/Org/MembersPage/components/OrgIdentityTab/components/IdentitySection/IdentityUniversalAuthForm.tsx +++ b/frontend/src/views/Org/MembersPage/components/OrgIdentityTab/components/IdentitySection/IdentityUniversalAuthForm.tsx @@ -223,7 +223,7 @@ export const IdentityUniversalAuthForm = ({ {...field} placeholder="2592000" type="number" - min="0" + min="1" step="1" />