awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-02 22:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

throw unauthorized error instead of 500 for permission denied

Browse Source
This commit is contained in:
Maidul Islam
2023-06-09 18:40:41 -07:00
parent 570457c7c9
commit bb7b398fa7
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/helpers/secrets.ts
+6 -5
View File
@@ -18,6 +18,7 @@ import {
SecretNotFoundError, SecretNotFoundError,
SecretBlindIndexDataNotFoundError, SecretBlindIndexDataNotFoundError,
InternalServerError, InternalServerError,
UnauthorizedRequestError,
} from "../utils/errors"; } from "../utils/errors";
import { import {
SECRET_PERSONAL, SECRET_PERSONAL,
@@ -302,7 +303,7 @@ export const createSecretHelper = async ({
if (authData.authPayload instanceof ServiceTokenData) { if (authData.authPayload instanceof ServiceTokenData) {
const { secretPath: serviceTkScopedSecretPath } = authData.authPayload; const { secretPath: serviceTkScopedSecretPath } = authData.authPayload;
if (secretPath !== serviceTkScopedSecretPath) { if (secretPath !== serviceTkScopedSecretPath) {
throw new Error("Folder Permission Denied"); throw UnauthorizedRequestError({ message: "Folder Permission Denied" });
} }
} }
const folderId = await getFolderIdFromServiceToken( const folderId = await getFolderIdFromServiceToken(
@@ -454,7 +455,7 @@ export const getSecretsHelper = async ({
if (authData.authPayload instanceof ServiceTokenData) { if (authData.authPayload instanceof ServiceTokenData) {
const { secretPath: serviceTkScopedSecretPath } = authData.authPayload; const { secretPath: serviceTkScopedSecretPath } = authData.authPayload;
if (secretPath !== serviceTkScopedSecretPath) { if (secretPath !== serviceTkScopedSecretPath) {
throw new Error("Folder Permission Denied"); throw UnauthorizedRequestError({ message: "Folder Permission Denied" });
} }
} }
const folderId = await getFolderIdFromServiceToken( const folderId = await getFolderIdFromServiceToken(
@@ -551,7 +552,7 @@ export const getSecretHelper = async ({
if (authData.authPayload instanceof ServiceTokenData) { if (authData.authPayload instanceof ServiceTokenData) {
const { secretPath: serviceTkScopedSecretPath } = authData.authPayload; const { secretPath: serviceTkScopedSecretPath } = authData.authPayload;
if (secretPath !== serviceTkScopedSecretPath) { if (secretPath !== serviceTkScopedSecretPath) {
throw new Error("Folder Permission Denied"); throw UnauthorizedRequestError({ message: "Folder Permission Denied" });
} }
} }
const folderId = await getFolderIdFromServiceToken( const folderId = await getFolderIdFromServiceToken(
@@ -658,7 +659,7 @@ export const updateSecretHelper = async ({
if (authData.authPayload instanceof ServiceTokenData) { if (authData.authPayload instanceof ServiceTokenData) {
const { secretPath: serviceTkScopedSecretPath } = authData.authPayload; const { secretPath: serviceTkScopedSecretPath } = authData.authPayload;
if (secretPath !== serviceTkScopedSecretPath) { if (secretPath !== serviceTkScopedSecretPath) {
throw new Error("Folder Permission Denied"); throw UnauthorizedRequestError({ message: "Folder Permission Denied" });
} }
} }
const folderId = await getFolderIdFromServiceToken( const folderId = await getFolderIdFromServiceToken(
@@ -811,7 +812,7 @@ export const deleteSecretHelper = async ({
if (authData.authPayload instanceof ServiceTokenData) { if (authData.authPayload instanceof ServiceTokenData) {
const { secretPath: serviceTkScopedSecretPath } = authData.authPayload; const { secretPath: serviceTkScopedSecretPath } = authData.authPayload;
if (secretPath !== serviceTkScopedSecretPath) { if (secretPath !== serviceTkScopedSecretPath) {
throw new Error("Folder Permission Denied"); throw UnauthorizedRequestError({ message: "Folder Permission Denied" });
} }
} }
const folderId = await getFolderIdFromServiceToken( const folderId = await getFolderIdFromServiceToken(