awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-05 15:26:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address greptile comments

Browse Source
This commit is contained in:
Carlos Monastyrski
2025-10-02 12:18:54 -03:00
parent 95df76de5a
commit bc527ca0d1
5 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/pki-sync/aws-certificate-manager/aws-certificate-manager-pki-sync-schemas.ts
+1 -1
View File
@@ -12,7 +12,7 @@ export const AwsCertificateManagerPkiSyncConfigSchema = z.object({
}); });
const AwsCertificateManagerPkiSyncOptionsSchema = z.object({ const AwsCertificateManagerPkiSyncOptionsSchema = z.object({
canImportCertificates: z.boolean().default(true), canImportCertificates: z.boolean().default(false),
canRemoveCertificates: z.boolean().default(true), canRemoveCertificates: z.boolean().default(true),
certificateNameSchema: z certificateNameSchema: z
.string() .string()
docs/api-reference/endpoints/pki/syncs/aws-certificate-manager/remove-certificates.mdx
+1 -1
View File
@@ -1,4 +1,4 @@
--- ---
title: "Remove Certificates from AWS Certificate Manager" title: "Remove Certificates from AWS Certificate Manager"
openapi: "POST /api/v1/pki/syncs/aws-certificate-manager/{pkiSyncId}/remove-certificates" openapi: "POST /api/v1/pki/syncs/aws-certificate-manager/{pkiSyncId}/remove-certificates"
--- ---
docs/documentation/platform/pki/certificate-syncs/aws-certificate-manager.mdx
+3 -4
View File
@@ -5,9 +5,9 @@ description: "Learn how to configure an AWS Certificate Manager Certificate Sync
**Prerequisites:** **Prerequisites:**
- Set up and configure a [Certificate Authority](/documentation/platform/pki/overview) - Set up and configure a [Certificate Authority](/documentation/platform/pki/overview)
- Create an [AWS Connection](/integrations/app-connections/aws) - Create an [AWS Connection](/integrations/app-connections/aws)
- Ensure your network security policies allow incoming requests from Infisical to this certificate sync provider, if network restrictions apply. - Ensure your network security policies allow incoming requests from Infisical to this certificate sync provider, if network restrictions apply.
<Note> <Note>
The AWS Certificate Manager Certificate Sync requires the following ACM permissions to be set on the IAM user/role The AWS Certificate Manager Certificate Sync requires the following ACM permissions to be set on the IAM user/role
@@ -38,7 +38,6 @@ description: "Learn how to configure an AWS Certificate Manager Certificate Sync
- **AWS Connection**: The AWS Connection to authenticate with. - **AWS Connection**: The AWS Connection to authenticate with.
- **AWS Region**: The AWS region where certificates should be stored. - **AWS Region**: The AWS region where certificates should be stored.
<p class="height:1px" />
5. Configure the **Sync Options** to specify how certificates should be synced, then click **Next**. 5. Configure the **Sync Options** to specify how certificates should be synced, then click **Next**.
![Configure Options](/images/certificate-syncs/aws-certificate-manager/acm-options.png) ![Configure Options](/images/certificate-syncs/aws-certificate-manager/acm-options.png)
frontend/src/components/pki-syncs/forms/schemas/azure-key-vault-pki-sync-destination-schema.ts
+5 -2
View File
@@ -8,7 +8,7 @@ export const AzureKeyVaultPkiSyncDestinationSchema = BasePkiSyncSchema().merge(
z.object({ z.object({
destination: z.literal(PkiSync.AzureKeyVault), destination: z.literal(PkiSync.AzureKeyVault),
destinationConfig: z.object({ destinationConfig: z.object({
vaultBaseUrl: z.string().url("Valid URL is required") vaultBaseUrl: z.string().min(1, "Vault base URL is required").url("Valid URL is required")
}) })
}) })
); );
@@ -24,7 +24,10 @@ export const UpdateAzureKeyVaultPkiSyncDestinationSchema =
destination: z.literal(PkiSync.AzureKeyVault), destination: z.literal(PkiSync.AzureKeyVault),
connection: z.object({ connection: z.object({
id: z.string().uuid("Invalid connection ID format"), id: z.string().uuid("Invalid connection ID format"),
name: z.string().max(255, "Connection name must be less than 255 characters") name: z
.string()
.min(1, "Connection name is required")
.max(255, "Connection name must be less than 255 characters")
}) })
}) })
); );
frontend/src/hooks/api/pkiSyncs/types/index.ts
+9 -3
View File
@@ -22,7 +22,7 @@ export type TListPkiSyncs = { pkiSyncs: TPkiSync[] };
export type TListPkiSyncOptions = { pkiSyncOptions: TPkiSyncOption[] }; export type TListPkiSyncOptions = { pkiSyncOptions: TPkiSyncOption[] };
export type TCreatePkiSyncDTO = { type TCreatePkiSyncDTOBase = {
name: string; name: string;
description?: string; description?: string;
connectionId: string; connectionId: string;
@@ -32,11 +32,17 @@ export type TCreatePkiSyncDTO = {
certificateNamePrefix?: string; certificateNamePrefix?: string;
certificateNameSchema?: string; certificateNameSchema?: string;
}; };
destination: PkiSync;
isAutoSyncEnabled: boolean; isAutoSyncEnabled: boolean;
subscriberId?: string; subscriberId?: string;
projectId: string; projectId: string;
destinationConfig: Record<string, any>; };
export type TCreatePkiSyncDTO = TCreatePkiSyncDTOBase & {
destination: PkiSync;
destinationConfig: {
vaultBaseUrl?: string;
region?: string;
};
}; };
export type TUpdatePkiSyncDTO = Partial<Omit<TCreatePkiSyncDTO, "projectId">> & { export type TUpdatePkiSyncDTO = Partial<Omit<TCreatePkiSyncDTO, "projectId">> & {