awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-15 18:15:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: addressed review comments

Browse Source
This commit is contained in:
Sheen Capadngan
2024-11-21 02:37:56 +08:00
parent 0c3894496c
commit bce3f3d676
6 changed files with 36 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/views/SecretMainPage/components/ActionBar/CreateDynamicSecretForm/TotpInputForm.tsx
+10 -2
View File
@@ -39,7 +39,11 @@ const formSchema = z.object({
}),
z.object({
configType: z.literal(ConfigType.MANUAL),
secret: z.string().min(1),
secret: z
.string()
.trim()
.min(1)
.transform((val) => val.replace(/\s+/g, "")),
period: z.number().optional(),
algorithm: z.nativeEnum(TotpAlgorithm).optional(),
digits: z.number().optional()
@@ -214,7 +218,7 @@ export const TotpInputForm = ({
</FormControl>
)}
/>
<div className="flex flex-row">
<div className="flex flex-row gap-2">
<Controller
control={control}
name="provider.period"
@@ -287,6 +291,10 @@ export const TotpInputForm = ({
)}
/>
</div>
<p className="mb-8 text-sm font-normal text-gray-400">
The period, digits, and algorithm values can remain at their defaults unless
your TOTP provider specifies otherwise.
</p>
</>
)}
</div>
frontend/src/views/SecretMainPage/components/DynamicSecretListView/DynamicSecretListView.tsx
+10
View File
@@ -101,10 +101,20 @@ export const DynamicSecretListView = ({
role="button"
tabIndex={0}
onKeyDown={(evt) => {
// no lease view for TOTP because it's irrelevant
if (secret.type === DynamicSecretProviders.Totp) {
return;
}
if (evt.key === "Enter" && !isRevoking)
handlePopUpOpen("dynamicSecretLeases", secret.id);
}}
onClick={() => {
// no lease view for TOTP because it's irrelevant
if (secret.type === DynamicSecretProviders.Totp) {
return;
}
if (!isRevoking) {
handlePopUpOpen("dynamicSecretLeases", secret.id);
}
frontend/src/views/SecretMainPage/components/DynamicSecretListView/EditDynamicSecretForm/EditDynamicSecretTotpForm.tsx
+6 -2
View File
@@ -40,7 +40,11 @@ const formSchema = z.object({
}),
z.object({
configType: z.literal(ConfigType.MANUAL),
secret: z.string().min(1),
secret: z
.string()
.trim()
.min(1)
.transform((val) => val.replace(/\s+/g, "")),
period: z.number().optional(),
algorithm: z.nativeEnum(TotpAlgorithm).optional(),
digits: z.number().optional()
@@ -218,7 +222,7 @@ export const EditDynamicSecretTotpForm = ({
</FormControl>
)}
/>
<div className="flex flex-row">
<div className="flex flex-row gap-2">
<Controller
control={control}
name="inputs.period"