feat(telemetry): addressed PR suggestions

This commit is contained in:
carlosmonastyrski
2025-06-27 14:30:31 -03:00
parent 0f04890d8f
commit be51e4372d
2 changed files with 4 additions and 8 deletions
@@ -55,11 +55,7 @@ export const telemetryQueueServiceFactory = ({
}); });
queueService.start(QueueName.TelemetryAggregatedEvents, async () => { queueService.start(QueueName.TelemetryAggregatedEvents, async () => {
try { await telemetryService.processAggregatedEvents();
await telemetryService.processAggregatedEvents();
} catch (error) {
logger.error(error, "Failed to process aggregated telemetry events");
}
}); });
// every day at midnight a telemetry job executes on self-hosted instances // every day at midnight a telemetry job executes on self-hosted instances
@@ -13,7 +13,7 @@ import { PostHogEventTypes, TPostHogEvent, TSecretModifiedEvent } from "./teleme
export const TELEMETRY_SECRET_PROCESSED_KEY = "telemetry-secret-processed"; export const TELEMETRY_SECRET_PROCESSED_KEY = "telemetry-secret-processed";
export const TELEMETRY_SECRET_OPERATIONS_KEY = "telemetry-secret-operations"; export const TELEMETRY_SECRET_OPERATIONS_KEY = "telemetry-secret-operations";
export const HOURLY_AGGREGATED_EVENTS = [PostHogEventTypes.SecretPulled]; export const POSTHOG_AGGREGATED_EVENTS = [PostHogEventTypes.SecretPulled];
const TELEMETRY_AGGREGATED_KEY_EXP = 600; // 10mins const TELEMETRY_AGGREGATED_KEY_EXP = 600; // 10mins
// Bucket configuration // Bucket configuration
@@ -109,7 +109,7 @@ To opt into telemetry, you can set "TELEMETRY_ENABLED=true" within the environme
logger.error(error, "Failed to identify PostHog organization"); logger.error(error, "Failed to identify PostHog organization");
} }
} }
if (HOURLY_AGGREGATED_EVENTS.includes(event.event)) { if (POSTHOG_AGGREGATED_EVENTS.includes(event.event)) {
const eventKey = createTelemetryEventKey(event.event, event.distinctId); const eventKey = createTelemetryEventKey(event.event, event.distinctId);
await keyStore.setItemWithExpiry( await keyStore.setItemWithExpiry(
eventKey, eventKey,
@@ -283,7 +283,7 @@ To opt into telemetry, you can set "TELEMETRY_ENABLED=true" within the environme
const processAggregatedEvents = async () => { const processAggregatedEvents = async () => {
if (!postHog) return; if (!postHog) return;
for (const eventType of HOURLY_AGGREGATED_EVENTS) { for (const eventType of POSTHOG_AGGREGATED_EVENTS) {
let totalProcessed = 0; let totalProcessed = 0;
logger.info(`Starting bucket processing for ${eventType}`); logger.info(`Starting bucket processing for ${eventType}`);