fix: improved filter

backend/src/server/routes/v3/secret-router.ts

@@ -181,68 +181,81 @@ export const registerSecretRouter = async (server: FastifyZodProvider) => {
         }
       ],
       querystring: z.object({
-        secretMetadata: z
+        filters: z
           .string()
           .optional()
           .transform((val) => {
+            // TODO: Add support for more filtering fields & operators.
+            // Currently only supports secretMetadata filtering in a specific format to allow for further expansion of filtering in the future.
+
             if (!val) return undefined;
+            const secretMetadataSection = [val].find((section) => section.startsWith("secretMetadata="));
 
-            const result: { key?: string; value?: string }[] = [];
+            if (!secretMetadataSection) return undefined;
-            const pairs = val.split(",");
 
-            for (const pair of pairs) {
+            const metadataContent = secretMetadataSection.replace("secretMetadata=", "");
-              const pairResult: { key?: string; value?: string } = {};
-              const parts = pair.split(/[:=]/).map((part) => part.trim());
 
-              for (let i = 0; i < parts.length - 1; i += 1) {
+            const secretMetadataResult: { key?: string; value?: string }[] = [];
-                const current = parts[i].toLowerCase();
+            let currentPair: { key?: string; value?: string } = {};
-                const next = parts[i + 1];
 
-                if (current === "key" && next) {
+            const parts = metadataContent.split(/(?<!=),(?!=)/);
-                  pairResult.key = next;
+
-                } else if (current === "value" && next) {
+            for (const part of parts) {
-                  pairResult.value = next;
+              const [type, value] = part.split("=");
+
+              if (type === "key") {
+                if (currentPair.key || currentPair.value) {
+                  secretMetadataResult.push(currentPair);
+                  currentPair = {};
                 }
-              }
+                currentPair.key = value;
-
+              } else if (type === "value") {
-              // Only add pair if at least one of key or value is present
+                currentPair.value = value;
-              if (pairResult.key || pairResult.value) {
+                secretMetadataResult.push(currentPair);
-                result.push(pairResult);
+                currentPair = {};
               }
             }
 
-            if (!result.length) return undefined;
+            if (currentPair.key || currentPair.value) {
+              secretMetadataResult.push(currentPair);
+            }
 
-            return result;
+            if (!secretMetadataResult.length) return undefined;
+
+            return {
+              secretMetadata: secretMetadataResult
+            };
           })
-          .superRefine((metadata, ctx) => {
+          .superRefine((filters, ctx) => {
-            if (metadata && !Array.isArray(metadata)) {
+            if (filters?.secretMetadata) {
-              ctx.addIssue({
+              if (!Array.isArray(filters.secretMetadata)) {
-                code: z.ZodIssueCode.custom,
+                ctx.addIssue({
-                message: "Invalid secretMetadata format. Correct format is key1:value1,key2:value2"
+                  code: z.ZodIssueCode.custom,
-              });
+                  message:
-            }
+                    "Invalid secretMetadata format in filters. Correct format is filters=secretMetadata=key=key1,value=val1"
+                });
+              }
 
-            if (metadata) {
+              if (filters.secretMetadata.length > 10) {
-              if (metadata.length > 10) {
                 ctx.addIssue({
                   code: z.ZodIssueCode.custom,
                   message: "You can only filter by up to 10 metadata fields"
                 });
               }
 
-              for (const item of metadata) {
+              for (const item of filters.secretMetadata) {
                 if (!item.key && !item.value) {
                   ctx.addIssue({
                     code: z.ZodIssueCode.custom,
                     message:
-                      "Invalid secretMetadata format, key or value must be provided. Correct format is key1:value1,key2:value2"
+                      "Invalid secretMetadata format in filters, key or value must be provided. Correct format is filters=secretMetadata=key=key1,value=val1"
                   });
                 }
               }
             }
           })
           .describe(RAW_SECRETS.LIST.secretMetadata),
+
         workspaceId: z.string().trim().optional().describe(RAW_SECRETS.LIST.workspaceId),
         workspaceSlug: z.string().trim().optional().describe(RAW_SECRETS.LIST.workspaceSlug),
         environment: z.string().trim().optional().describe(RAW_SECRETS.LIST.environment),
@@ -343,7 +356,7 @@ export const registerSecretRouter = async (server: FastifyZodProvider) => {
         actorAuthMethod: req.permission.authMethod,
         projectId: workspaceId,
         path: secretPath,
-        secretMetadata: req.query.secretMetadata,
+        secretMetadata: req.query.filters?.secretMetadata,
         includeImports: req.query.include_imports,
         recursive: req.query.recursive,
         tagSlugs: req.query.tagSlugs