awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-06 19:28:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address greptile comments

Browse Source
This commit is contained in:
Carlos Monastyrski
2025-11-22 01:14:10 -03:00
parent 0f32784834
commit c0060c1d22
5 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/db/migrations/20251121124532_add-issuer-type-to-certificate-profiles.ts
-4
View File
@@ -24,8 +24,4 @@ export async function down(knex: Knex): Promise<void> {
t.dropColumn("issuerType"); t.dropColumn("issuerType");
}); });
} }
await knex.schema.alterTable(TableName.PkiCertificateProfile, (t) => {
t.uuid("caId").notNullable().alter();
});
} }
backend/src/services/certificate-profile/certificate-profile-service.ts
+1 -3
View File
@@ -415,9 +415,7 @@ export const certificateProfileServiceFactory = ({
validateIssuerTypeConstraints(finalIssuerType, finalEnrollmentType, finalCaId ?? null, existingProfile.caId); validateIssuerTypeConstraints(finalIssuerType, finalEnrollmentType, finalCaId ?? null, existingProfile.caId);
const updatedData = const updatedData =
finalIssuerType === IssuerType.SELF_SIGNED && existingProfile.caId && data.issuerType === IssuerType.SELF_SIGNED finalIssuerType === IssuerType.SELF_SIGNED && existingProfile.caId ? { ...data, caId: null } : data;
? { ...data, caId: null }
: data;
const { estConfig, apiConfig, ...profileUpdateData } = updatedData; const { estConfig, apiConfig, ...profileUpdateData } = updatedData;
backend/src/services/certificate-v3/certificate-v3-service.test.ts
+1 -1
View File
@@ -1792,7 +1792,7 @@ describe("CertificateV3Service", () => {
certificateId: "cert-123", certificateId: "cert-123",
...mockActor ...mockActor
}) })
).rejects.toThrow("Only certificates issued from a profile or self-signed certificates can be renewed"); ).rejects.toThrow("Only certificates issued from a profile can be renewed");
}); });
it("should reject renewal if certificate was issued from CSR (external private key)", async () => { it("should reject renewal if certificate was issued from CSR (external private key)", async () => {
backend/src/services/certificate-v3/certificate-v3-service.ts
+2 -3
View File
@@ -1191,10 +1191,9 @@ export const certificateV3ServiceFactory = ({
throw new NotFoundError({ message: "Certificate not found" }); throw new NotFoundError({ message: "Certificate not found" });
} }
const isSelfSigned = !originalCert.profileId && !originalCert.caId && originalCert.certificateTemplateId === null; if (!originalCert.profileId) {
if (!originalCert.profileId && !originalCert.caId && !isSelfSigned) {
throw new ForbiddenRequestError({ throw new ForbiddenRequestError({
message: "Only certificates issued from a profile or self-signed certificates can be renewed" message: "Only certificates issued from a profile can be renewed"
}); });
} }
frontend/src/pages/cert-manager/PoliciesPage/components/CertificateProfilesTab/ProfileRow.tsx
+1 -1
View File
@@ -49,7 +49,7 @@ export const ProfileRow = ({
}: Props) => { }: Props) => {
const { permission } = useProjectPermission(); const { permission } = useProjectPermission();
const { data: caData } = useGetCaById(profile.caId || ""); const { data: caData } = useGetCaById(profile.caId ?? "");
const { popUp, handlePopUpToggle } = usePopUp(["issueCertificate"] as const); const { popUp, handlePopUpToggle } = usePopUp(["issueCertificate"] as const);