awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 14:27:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: update e2e tests for folder creation and handle duplicate folder error

Browse Source
This commit is contained in:
Piyush Gupta
2025-10-18 00:45:49 +05:30
parent ba98419303
commit c0d6d8c41d
2 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/e2e-test/routes/v1/secret-folder.spec.ts
+23 -2
View File
@@ -40,7 +40,7 @@ describe("Secret Folder Router", async () => {
{ name: "folder1", path: "/" }, // one in root { name: "folder1", path: "/" }, // one in root
{ name: "folder1", path: "/level1/level2" }, // then create a deep one creating intermediate ones { name: "folder1", path: "/level1/level2" }, // then create a deep one creating intermediate ones
{ name: "folder2", path: "/" }, { name: "folder2", path: "/" },
{ name: "folder1", path: "/level1/level2" } // this should not create folder return same thing { name: "folder3", path: "/level1/level2" }
])("Create folder $name in $path", async ({ name, path }) => { ])("Create folder $name in $path", async ({ name, path }) => {
const createdFolder = await createFolder({ path, name }); const createdFolder = await createFolder({ path, name });
// check for default environments // check for default environments
@@ -57,7 +57,7 @@ describe("Secret Folder Router", async () => {
{ {
path: "/", path: "/",
expected: { expected: {
folders: [{ name: "folder1" }, { name: "level1" }, { name: "folder2" }], folders: [{ name: "folder4" }, { name: "level2" }, { name: "folder5" }],
length: 3 length: 3
} }
}, },
@@ -162,4 +162,25 @@ describe("Secret Folder Router", async () => {
expect(updatedFolderList).toHaveProperty("folders"); expect(updatedFolderList).toHaveProperty("folders");
expect(updatedFolderList.folders.length).toEqual(0); expect(updatedFolderList.folders.length).toEqual(0);
}); });
test("Creating a duplicate folder should return a 400 error", async () => {
const newFolder = await createFolder({ name: "folder-duplicate", path: "/level1/level2" });
const res = await testServer.inject({
method: "POST",
url: `/api/v1/folders`,
headers: {
authorization: `Bearer ${jwtAuthToken}`
},
body: {
workspaceId: seedData1.project.id,
environment: seedData1.environment.slug,
name: "folder-duplicate",
path: "/level1/level2"
}
});
expect(res.statusCode).toBe(400);
const payload = JSON.parse(res.payload);
expect(payload).toHaveProperty("error");
await deleteFolder({ path: "/level1/level2", id: newFolder.id });
});
}); });
backend/e2e-test/routes/v2/secret-folder.spec.ts
+2 -1
View File
@@ -165,7 +165,7 @@ describe("Secret Folder Router", async () => {
}); });
test("Creating a duplicate folder should return a 400 error", async () => { test("Creating a duplicate folder should return a 400 error", async () => {
await createFolder({ name: "folder-duplicate", path: "/level1/level2" }); const newFolder = await createFolder({ name: "folder-duplicate", path: "/level1/level2" });
const res = await testServer.inject({ const res = await testServer.inject({
method: "POST", method: "POST",
@@ -183,5 +183,6 @@ describe("Secret Folder Router", async () => {
expect(res.statusCode).toBe(400); expect(res.statusCode).toBe(400);
const payload = JSON.parse(res.payload); const payload = JSON.parse(res.payload);
expect(payload).toHaveProperty("error"); expect(payload).toHaveProperty("error");
await deleteFolder({ path: "/level1/level2", id: newFolder.id });
}); });
}); });