Fix upstream skip validation

This commit is contained in:
Fang-Pen Lin
2025-11-13 11:36:51 -08:00
parent 73a3ee6b61
commit c183d91257
4 changed files with 5 additions and 3 deletions
@@ -243,7 +243,7 @@ export const orderCertificate = async (
challengePriority: ["dns-01"],
// For ACME development mode, we mock the DNS challenge API calls. So, no real DNS records are created.
// We need to disable the challenge verification to avoid errors.
skipChallengeVerification: getConfig().isAcmeDevelopmentMode,
skipChallengeVerification: getConfig().isAcmeDevelopmentMode && getConfig().ACME_SKIP_UPSTREAM_VALIDATION,
termsOfServiceAgreed: true,
challengeCreateFn: async (authz, challenge, keyAuthorization) => {
@@ -68,8 +68,6 @@ export const cloudflareDeleteTxtRecord = async (
},
params: {
type: "TXT",
// TODO: this is incorrect. The domain seems need to be fqdn, but we are passing just the record name here.
// as a result, we are not deleting the record correctly.
name: domain,
content: value
}