awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 15:27:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Greptile review fixes

Browse Source
This commit is contained in:
x032205
2025-05-21 18:17:01 -04:00
parent e3725dd3ab
commit c1fa344f02
4 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/routes/v1/access-approval-request-router.ts
+1 -1
View File
@@ -156,7 +156,7 @@ export const registerAccessApprovalRequestRouter = async (server: FastifyZodProv
body: z.object({ body: z.object({
status: z.enum([ApprovalStatus.APPROVED, ApprovalStatus.REJECTED]), status: z.enum([ApprovalStatus.APPROVED, ApprovalStatus.REJECTED]),
envName: z.string().optional(), // For logging envName: z.string().optional(), // For logging
bypassReason: z.string().optional() bypassReason: z.string().min(10).max(1000).optional()
}), }),
response: { response: {
200: z.object({ 200: z.object({
docs/documentation/platform/access-controls/access-requests.mdx
+1 -1
View File
@@ -19,7 +19,7 @@ This functionality works in the following way:
![Access Request Bypass](/images/platform/access-controls/access-request-bypass.png) ![Access Request Bypass](/images/platform/access-controls/access-request-bypass.png)
<Info> <Info>
If the access request matches with a policy that has allows break-glass approval bypasses, the requester may bypass the policy and get access to the resource without full approval. If the access request matches with a policy that allows break-glass approval bypasses, the requester may bypass the policy and get access to the resource without full approval.
</Info> </Info>
5. As soon as the request is approved, developer is able to access the sought resources. 5. As soon as the request is approved, developer is able to access the sought resources.
docs/documentation/platform/pr-workflows.mdx
+3 -1
View File
@@ -33,7 +33,9 @@ First, you would need to create a set of policies for a certain environment. In
The enforcement level determines how strict the policy is. A **Hard** enforcement level means that any change that matches the policy will need full approval prior merging. A **Soft** enforcement level allows for break glass functionality on the request. If a change request is bypassed, the approvers will be notified via email. The enforcement level determines how strict the policy is. A **Hard** enforcement level means that any change that matches the policy will need full approval prior merging. A **Soft** enforcement level allows for break glass functionality on the request. If a change request is bypassed, the approvers will be notified via email.
You can use the **Soft** enforcement level by enabling "Bypass Approvals". <Note>
Enabling the "Bypass Approvals" toggle during policy creation will create a **Soft** enforcement level. Disabling the toggle makes the enforcement level **Hard**.
</Note>
### Self approvals ### Self approvals
docs/internals/permissions/project-permissions.mdx
+8 -8
View File
@@ -178,14 +178,14 @@ Supports conditions and permission inversion
#### Subject: `secret-approval` #### Subject: `secret-approval`
| Action | Description | | Action | Description |
| --------------------- | ---------------------------------------------------------------------------- | | --------------------- | ----------------------------------------------------------------------------------- |
| `read` | View approval policies and requests | | `read` | View approval policies and requests |
| `create` | Create new approval policies | | `create` | Create new approval policies |
| `edit` | Modify approval policies | | `edit` | Modify approval policies |
| `delete` | Remove approval policies | | `delete` | Remove approval policies |
| `allow-change-bypass` | Allow request creators to bypass policy in break-glass situations | | `allow-change-bypass` | Allow request creators to merge changes without approval in break-glass situations |
| `allow-access-bypass` | Allow request creators to bypass policy in break-glass situations | | `allow-access-bypass` | Allow request creators to access secrets without approval in break-glass situations |
#### Subject: `secret-rotation` #### Subject: `secret-rotation`