From c229d6888ce6bdbcdbbf91a8e36cddff27862a5e Mon Sep 17 00:00:00 2001 From: carlosmonastyrski Date: Fri, 25 Apr 2025 20:41:44 -0300 Subject: [PATCH] feat(secrets-ui): allow read access to personal overrides --- backend/src/services/secret-v2-bridge/secret-v2-bridge-fns.ts | 4 ++-- .../components/SecretOverviewTableRow/SecretEditRow.tsx | 2 +- .../SecretOverviewTableRow/SecretOverviewTableRow.tsx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/backend/src/services/secret-v2-bridge/secret-v2-bridge-fns.ts b/backend/src/services/secret-v2-bridge/secret-v2-bridge-fns.ts index f42deb8ff..7b03ca089 100644 --- a/backend/src/services/secret-v2-bridge/secret-v2-bridge-fns.ts +++ b/backend/src/services/secret-v2-bridge/secret-v2-bridge-fns.ts @@ -2,7 +2,7 @@ import path from "node:path"; import RE2 from "re2"; -import { TableName, TSecretFolders, TSecretsV2 } from "@app/db/schemas"; +import { SecretType, TableName, TSecretFolders, TSecretsV2 } from "@app/db/schemas"; import { ForbiddenRequestError, NotFoundError } from "@app/lib/errors"; import { groupBy } from "@app/lib/fn"; import { logger } from "@app/lib/logger"; @@ -717,7 +717,7 @@ export const reshapeBridgeSecret = ( rotationId: secret.rotationId, ...(secretValueHidden ? { - secretValue: INFISICAL_SECRET_VALUE_HIDDEN_MASK, + secretValue: secret.type === SecretType.Personal ? secret.value : INFISICAL_SECRET_VALUE_HIDDEN_MASK, secretValueHidden: true } : { diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx index a3e977608..6d21ca6e1 100644 --- a/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx +++ b/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretEditRow.tsx @@ -125,7 +125,7 @@ export const SecretEditRow = ({ ); } } - if (secretValueHidden) { + if (secretValueHidden && !isOverride) { setTimeout(() => { reset({ value: defaultValue || null }); }, 50); diff --git a/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretOverviewTableRow.tsx b/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretOverviewTableRow.tsx index 0b2f7d07b..c6dbb555b 100644 --- a/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretOverviewTableRow.tsx +++ b/frontend/src/pages/secret-manager/OverviewPage/components/SecretOverviewTableRow/SecretOverviewTableRow.tsx @@ -86,7 +86,7 @@ export const SecretOverviewTableRow = ({ }) ); - if (secret?.secretValueHidden) { + if (secret?.secretValueHidden && !secret?.valueOverride) { return canEditSecretValue ? "******" : ""; } return secret?.valueOverride || secret?.value || importedSecret?.secret?.value || "";