From c4c0f865987b380e2f175d8b883acad1de84b53d Mon Sep 17 00:00:00 2001
From: carlosmonastyrski <charly.monastyrski@gmail.com>
Date: Wed, 25 Jun 2025 13:51:38 -0300
Subject: [PATCH] feat(secret-sync): improve update logic and add warning on
 docs for gitlab limitation on hidden variables

---
 backend/src/services/secret-sync/gitlab/gitlab-sync-fns.ts   | 4 ++--
 backend/src/services/secret-sync/gitlab/gitlab-sync-types.ts | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/backend/src/services/secret-sync/gitlab/gitlab-sync-fns.ts b/backend/src/services/secret-sync/gitlab/gitlab-sync-fns.ts
index 8decf9fbd..3c152d853 100644
--- a/backend/src/services/secret-sync/gitlab/gitlab-sync-fns.ts
+++ b/backend/src/services/secret-sync/gitlab/gitlab-sync-fns.ts
@@ -339,8 +339,8 @@ export const GitLabSyncFns = {
                 variable: {
                   value,
                   environment_scope: targetEnvironment,
-                  protected: destinationConfig.shouldProtectSecrets ?? existingVariable.protected,
-                  masked: existingVariable.masked || destinationConfig.shouldMaskSecrets
+                  protected: destinationConfig.shouldProtectSecrets,
+                  masked: destinationConfig.shouldMaskSecrets || existingVariable.hidden
                 },
                 targetEnvironment
               });
diff --git a/backend/src/services/secret-sync/gitlab/gitlab-sync-types.ts b/backend/src/services/secret-sync/gitlab/gitlab-sync-types.ts
index 1f11e8a80..7a52a4126 100644
--- a/backend/src/services/secret-sync/gitlab/gitlab-sync-types.ts
+++ b/backend/src/services/secret-sync/gitlab/gitlab-sync-types.ts
@@ -18,6 +18,7 @@ export type TGitLabVariable = {
   protected: boolean;
   masked: boolean;
   environmentScope?: string;
+  hidden?: boolean;
 };
 
 export type TGitLabVariableCreate = {