awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-07 14:27:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong CSR format

Browse Source
This commit is contained in:
Fang-Pen Lin
2025-11-13 12:02:05 -08:00
parent 8895c52031
commit c510d841b8
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/ee/services/pki-acme/pki-acme-service.ts
+3 -1
View File
@@ -729,6 +729,8 @@ export const pkiAcmeServiceFactory = ({
return { certificateId: result.certificateId }; return { certificateId: result.certificateId };
} }
const { certificateAuthority } = (await certificateProfileDAL.findByIdWithConfigs(profileId, tx))!; const { certificateAuthority } = (await certificateProfileDAL.findByIdWithConfigs(profileId, tx))!;
const csrObj = new x509.Pkcs10CertificateRequest(csr);
const csrPem = csrObj.toString("pem");
// TODO: for internal CA, we rely on the internal certificate authority service to check CSR against the template // TODO: for internal CA, we rely on the internal certificate authority service to check CSR against the template
// we should check the CSR against the template here // we should check the CSR against the template here
// TODO: this is pretty slow, and we are holding the transaction open for a long time, // TODO: this is pretty slow, and we are holding the transaction open for a long time,
@@ -738,7 +740,7 @@ export const pkiAcmeServiceFactory = ({
caId: certificateAuthority!.id, caId: certificateAuthority!.id,
commonName: certificateRequest.commonName!, commonName: certificateRequest.commonName!,
altNames: certificateRequest.subjectAlternativeNames?.map((san) => san.value), altNames: certificateRequest.subjectAlternativeNames?.map((san) => san.value),
csr: Buffer.from(csr), csr: Buffer.from(csrPem),
// TODO: not 100% sure what are these columns for, but let's put the values for common website SSL certs for now // TODO: not 100% sure what are these columns for, but let's put the values for common website SSL certs for now
keyUsages: [CertKeyUsage.DIGITAL_SIGNATURE, CertKeyUsage.KEY_ENCIPHERMENT, CertKeyUsage.KEY_AGREEMENT], keyUsages: [CertKeyUsage.DIGITAL_SIGNATURE, CertKeyUsage.KEY_ENCIPHERMENT, CertKeyUsage.KEY_AGREEMENT],
extendedKeyUsages: [CertExtendedKeyUsage.SERVER_AUTH] extendedKeyUsages: [CertExtendedKeyUsage.SERVER_AUTH]