feat: fixed review comments

backend/src/db/migrations/20241205160300_project-split-to-products.ts

@@ -202,7 +202,7 @@ export async function up(knex: Knex): Promise<void> {
       .select("projectId");
     for (const { projectId } of projectsWithCmek) {
       if (projectId) {
-        const newProjectId = await newProject(knex, projectId, ProjectType.Cmek);
+        const newProjectId = await newProject(knex, projectId, ProjectType.KMS);
         await knex(TableName.KmsKey)
           .where({
             isReserved: false,
@@ -211,14 +211,13 @@ export async function up(knex: Knex): Promise<void> {
           .update({ projectId: newProjectId });
         await knex(TableName.ProjectSplitBackfillIds).insert({
           sourceProjectId: projectId,
-          destinationProjectType: ProjectType.Cmek,
+          destinationProjectType: ProjectType.KMS,
           destinationProjectId: newProjectId
         });
       }
     }
 
     /* eslint-enable */
-
     await knex.schema.alterTable(TableName.Project, (t) => {
       t.string("type").notNullable().alter();
     });

backend/src/db/schemas/models.ts

@@ -205,5 +205,5 @@ export enum IdentityAuthMethod {
 export enum ProjectType {
   SecretManager = "secret-manager",
   CertificateManager = "cert-manager",
-  Cmek = "cmek"
+  KMS = "kms"
 }

backend/src/db/schemas/projects.ts

@@ -25,7 +25,7 @@ export const ProjectsSchema = z.object({
   kmsSecretManagerKeyId: z.string().uuid().nullable().optional(),
   kmsSecretManagerEncryptedDataKey: zodBuffer.nullable().optional(),
   description: z.string().nullable().optional(),
-  type: z.string().nullable().optional()
+  type: z.string()
 });
 
 export type TProjects = z.infer<typeof ProjectsSchema>;