feat: fixed review comments

This commit is contained in:
=
2024-12-13 21:38:43 +05:30
parent 9b4e1f561e
commit c57fc5e3f1
37 changed files with 148 additions and 83 deletions
+5 -5
View File
@@ -352,7 +352,7 @@ export const AppLayout = ({ children }: LayoutProps) => {
)}
icon="system-outline-165-view-carousel"
>
Secret Manager
Secret Management
</MenuItem>
</a>
</Link>
@@ -367,17 +367,17 @@ export const AppLayout = ({ children }: LayoutProps) => {
)}
icon="system-outline-165-view-carousel"
>
Cert Manager
Cert Management
</MenuItem>
</a>
</Link>
<Link href={`/org/${currentOrg?.id}/${ProjectType.Cmek}/overview`} passHref>
<Link href={`/org/${currentOrg?.id}/${ProjectType.KMS}/overview`} passHref>
<a>
<MenuItem
isSelected={router.asPath.includes(`/${ProjectType.Cmek}/overview`)}
isSelected={router.asPath.includes(`/${ProjectType.KMS}/overview`)}
icon="system-outline-165-view-carousel"
>
Cmek
Key Management
</MenuItem>
</a>
</Link>
@@ -16,7 +16,7 @@ import {
useSubscription,
useWorkspace
} from "@app/context";
import { getWorkspaceHomePage } from "@app/helpers/workspace";
import { getProjectHomePage } from "@app/helpers/project";
import { usePopUp } from "@app/hooks";
import { useUpdateUserProjectFavorites } from "@app/hooks/api/users/mutation";
import { useGetUserProjectFavorites } from "@app/hooks/api/users/queries";
@@ -191,7 +191,7 @@ export const ProjectSelect = () => {
// todo(akhi): this is not using react query because react query in overview is throwing error when envs are not exact same count
// to reproduce change this back to router.push and switch between two projects with different env count
// look into this on dashboard revamp
window.location.assign(getWorkspaceHomePage(project));
window.location.assign(getProjectHomePage(project));
}}
options={options}
components={{
@@ -31,7 +31,7 @@ export const ProjectSidebarItem = () => {
const isSecretManager = currentWorkspace?.type === ProjectType.SecretManager;
const isCertManager = currentWorkspace?.type === ProjectType.CertificateManager;
const isCmek = currentWorkspace?.type === ProjectType.Cmek;
const isCmek = currentWorkspace?.type === ProjectType.KMS;
return (
<Menu>
@@ -71,10 +71,10 @@ export const ProjectSidebarItem = () => {
</Link>
)}
{isCmek && (
<Link href={`/${ProjectType.Cmek}/${currentWorkspace?.id}/kms`} passHref>
<Link href={`/${ProjectType.KMS}/${currentWorkspace?.id}/kms`} passHref>
<a>
<MenuItem
isSelected={router.asPath === `/${ProjectType.Cmek}/${currentWorkspace?.id}/kms`}
isSelected={router.asPath === `/${ProjectType.KMS}/${currentWorkspace?.id}/kms`}
icon="system-outline-90-lock-closed"
>
Key Management