feat: fixed review comments

This commit is contained in:
=
2024-12-13 21:38:43 +05:30
parent 9b4e1f561e
commit c57fc5e3f1
37 changed files with 148 additions and 83 deletions
@@ -2,7 +2,7 @@ import { ProjectType } from "@app/hooks/api/workspace/types";
import { ProductOverview } from "../secret-manager/overview";
const CmekManagerOverviewPage = () => <ProductOverview type={ProjectType.Cmek} />;
const CmekManagerOverviewPage = () => <ProductOverview type={ProjectType.KMS} />;
Object.assign(CmekManagerOverviewPage, { requireAuth: true });
@@ -2,6 +2,7 @@ import { useEffect } from "react";
import { useRouter } from "next/router";
import { useOrganization } from "@app/context";
import { ProjectType } from "@app/hooks/api/workspace/types";
// #TODO: Update all the workspaceIds
const OrganizationPage = () => {
@@ -9,7 +10,7 @@ const OrganizationPage = () => {
const { currentOrg } = useOrganization();
useEffect(() => {
if (router.isReady && currentOrg?.id) {
router.push(`/org/${currentOrg?.id}/secret-manager/overview`);
router.push(`/org/${currentOrg?.id}/${ProjectType.SecretManager}/overview`);
}
}, [router.isReady, currentOrg?.id]);
@@ -38,7 +38,7 @@ import {
useOrganization,
useSubscription
} from "@app/context";
import { getWorkspaceHomePage } from "@app/helpers/workspace";
import { getProjectHomePage } from "@app/helpers/project";
import { usePagination, useResetPageHelper } from "@app/hooks";
import { useGetUserWorkspaces } from "@app/hooks/api";
import { OrderByDirection } from "@app/hooks/api/generic/types";
@@ -60,9 +60,17 @@ enum ProjectOrderBy {
}
const formatTitle = (type: ProjectType) => {
if (type === ProjectType.SecretManager) return "Secret Managers";
if (type === ProjectType.CertificateManager) return "Cert Managers";
return "Cmek";
if (type === ProjectType.SecretManager) return "Secret Management";
if (type === ProjectType.CertificateManager) return "Cert Management";
return "Key Management";
};
const formatDescription = (type: ProjectType) => {
if (type === ProjectType.SecretManager)
return "Securely store, manage, and rotate various application secrets, such as database credentials, API keys, etc.";
if (type === ProjectType.CertificateManager)
return "Manage your PKI infrastructure and issue digital certificates for services, applications, and devices.";
return "Centralize the management of keys for cryptographic operations, such as encryption and decryption.";
};
type Props = {
@@ -182,7 +190,7 @@ export const ProductOverview = ({ type }: Props) => {
// eslint-disable-next-line jsx-a11y/no-static-element-interactions, jsx-a11y/click-events-have-key-events
<div
onClick={() => {
router.push(getWorkspaceHomePage(workspace));
router.push(getProjectHomePage(workspace));
localStorage.setItem("projectData.id", workspace.id);
}}
key={workspace.id}
@@ -246,7 +254,7 @@ export const ProductOverview = ({ type }: Props) => {
// eslint-disable-next-line jsx-a11y/no-static-element-interactions, jsx-a11y/click-events-have-key-events
<div
onClick={() => {
router.push(getWorkspaceHomePage(workspace));
router.push(getProjectHomePage(workspace));
localStorage.setItem("projectData.id", workspace.id);
}}
key={workspace.id}
@@ -382,9 +390,12 @@ export const ProductOverview = ({ type }: Props) => {
</div>
</div>
)}
<div className="mb-4 flex flex-col items-start justify-start px-6 py-6 pb-0 text-3xl">
<div className="mb-4 flex flex-col items-start justify-start px-6 py-6 pb-0">
<div className="flex w-full justify-between">
<p className="mr-4 font-semibold text-white">{formatTitle(type)}</p>
<p className="mr-4 text-3xl font-semibold text-white">{formatTitle(type)}</p>
</div>
<div>
<p className="mr-4 mt-2 text-gray-400">{formatDescription(type)}</p>
</div>
<div className="mt-6 flex w-full flex-row">
<Input