awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Requesting approvals on previously rejected resources

Browse Source
This commit is contained in:
Daniel Hougaard
2024-04-05 18:57:14 -07:00
parent 1785548a40
commit c7d2dfd351
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
backend/src/ee/services/access-approval-request/access-approval-request-service.ts
View File

@@ -128,9 +128,17 @@ export const accessApprovalRequestServiceFactory = ({
throw new BadRequestError({ message: "You already have an active privilege with the same criteria" }); throw new BadRequestError({ message: "You already have an active privilege with the same criteria" });
} }
} else { } else {
const reviewers = await accessApprovalRequestReviewerDAL.find({
requestId: duplicateRequest.id
});
const isRejected = reviewers.some((reviewer) => reviewer.status === ApprovalStatus.REJECTED);
if (!isRejected) {
throw new BadRequestError({ message: "You already have a pending access request with the same criteria" }); throw new BadRequestError({ message: "You already have a pending access request with the same criteria" });
} }
} }
}
const approval = await accessApprovalRequestDAL.transaction(async (tx) => { const approval = await accessApprovalRequestDAL.transaction(async (tx) => {
const approvalRequest = await accessApprovalRequestDAL.create( const approvalRequest = await accessApprovalRequestDAL.create(