From c8553fba2b04f28ee13e376392a4c0938a91e8e5 Mon Sep 17 00:00:00 2001 From: = Date: Tue, 25 Mar 2025 01:53:52 +0530 Subject: [PATCH] feat: updated nitpicks --- .../identity-project-additional-privilege-service.ts | 2 +- .../project-user-additional-privilege-service.ts | 2 +- backend/src/services/project-role/project-role-service.ts | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backend/src/ee/services/identity-project-additional-privilege/identity-project-additional-privilege-service.ts b/backend/src/ee/services/identity-project-additional-privilege/identity-project-additional-privilege-service.ts index 530136bd2..9cda292f6 100644 --- a/backend/src/ee/services/identity-project-additional-privilege/identity-project-additional-privilege-service.ts +++ b/backend/src/ee/services/identity-project-additional-privilege/identity-project-additional-privilege-service.ts @@ -208,7 +208,7 @@ export const identityProjectAdditionalPrivilegeServiceFactory = ({ } const isTemporary = typeof data?.isTemporary !== "undefined" ? data.isTemporary : identityPrivilege.isTemporary; - validateHandlebarTemplate("Identity Additional Privilege Create", JSON.stringify(data.permissions || []), { + validateHandlebarTemplate("Identity Additional Privilege Update", JSON.stringify(data.permissions || []), { allowedExpressions: (val) => val.includes("identity.") }); diff --git a/backend/src/ee/services/project-user-additional-privilege/project-user-additional-privilege-service.ts b/backend/src/ee/services/project-user-additional-privilege/project-user-additional-privilege-service.ts index e9de176a5..07bc7d4d3 100644 --- a/backend/src/ee/services/project-user-additional-privilege/project-user-additional-privilege-service.ts +++ b/backend/src/ee/services/project-user-additional-privilege/project-user-additional-privilege-service.ts @@ -93,7 +93,7 @@ export const projectUserAdditionalPrivilegeServiceFactory = ({ if (existingSlug) throw new BadRequestError({ message: `Additional privilege with provided slug ${slug} already exists` }); - validateHandlebarTemplate("User Additional Privilege Update", JSON.stringify(customPermission || []), { + validateHandlebarTemplate("User Additional Privilege Create", JSON.stringify(customPermission || []), { allowedExpressions: (val) => val.includes("identity.") }); diff --git a/backend/src/services/project-role/project-role-service.ts b/backend/src/services/project-role/project-role-service.ts index 43adcfbc8..3dfe11d2c 100644 --- a/backend/src/services/project-role/project-role-service.ts +++ b/backend/src/services/project-role/project-role-service.ts @@ -73,13 +73,13 @@ export const projectRoleServiceFactory = ({ throw new BadRequestError({ name: "Create Role", message: "Project role with same slug already exists" }); } + validateHandlebarTemplate("Project Role Create", JSON.stringify(data.permissions || []), { + allowedExpressions: (val) => val.includes("identity.") + }); const role = await projectRoleDAL.create({ ...data, projectId }); - validateHandlebarTemplate("Project Role Create", JSON.stringify(data.permissions || []), { - allowedExpressions: (val) => val.includes("identity.") - }); return { ...role, permissions: unpackPermissions(role.permissions) }; }; @@ -138,7 +138,7 @@ export const projectRoleServiceFactory = ({ if (existingRole && existingRole.id !== roleId) throw new BadRequestError({ name: "Update Role", message: "Project role with the same slug already exists" }); } - validateHandlebarTemplate("Project Role Upadte", JSON.stringify(data.permissions || []), { + validateHandlebarTemplate("Project Role Update", JSON.stringify(data.permissions || []), { allowedExpressions: (val) => val.includes("identity.") }); const updatedRole = await projectRoleDAL.updateById(projectRole.id, {