From cd03107a60f97f529319eb39be16c793637da019 Mon Sep 17 00:00:00 2001 From: Carlos Monastyrski Date: Wed, 30 Jul 2025 16:42:02 -0300 Subject: [PATCH] Minor frontend fixes on Azure App Connection forms --- .../AzureAppConfigurationConnectionForm.tsx | 10 +++++++--- .../AzureClientSecretsConnectionForm.tsx | 10 +++++++--- .../AppConnectionForm/AzureDevOpsConnectionForm.tsx | 10 +++++++--- .../AppConnectionForm/AzureKeyVaultConnectionForm.tsx | 10 +++++++--- 4 files changed, 28 insertions(+), 12 deletions(-) diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureAppConfigurationConnectionForm.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureAppConfigurationConnectionForm.tsx index cb0f955c8..433abf076 100644 --- a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureAppConfigurationConnectionForm.tsx +++ b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureAppConfigurationConnectionForm.tsx @@ -120,7 +120,7 @@ export const AzureAppConfigurationConnectionForm = ({ appConnection, onSubmit }: const selectedMethod = watch("method"); - const onSubmitHandler = (formData: FormData) => { + const onSubmitHandler = async (formData: FormData) => { const state = crypto.randomBytes(16).toString("hex"); switch (formData.method) { case AzureAppConfigurationConnectionMethod.OAuth: @@ -135,7 +135,7 @@ export const AzureAppConfigurationConnectionForm = ({ appConnection, onSubmit }: ); break; case AzureAppConfigurationConnectionMethod.ClientSecret: - onSubmit(formData); + await onSubmit(formData); break; default: throw new Error(`Unhandled Azure Connection method: ${(formData as FormData).method}`); @@ -249,7 +249,11 @@ export const AzureAppConfigurationConnectionForm = ({ appConnection, onSubmit }: label="Client Secret" errorText={error?.message} > - + )} /> diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureClientSecretsConnectionForm.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureClientSecretsConnectionForm.tsx index f6c5788f4..6f70f789e 100644 --- a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureClientSecretsConnectionForm.tsx +++ b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureClientSecretsConnectionForm.tsx @@ -121,7 +121,7 @@ export const AzureClientSecretsConnectionForm = ({ appConnection, onSubmit }: Pr const selectedMethod = watch("method"); - const onSubmitHandler = (formData: FormData) => { + const onSubmitHandler = async (formData: FormData) => { const state = crypto.randomBytes(16).toString("hex"); switch (formData.method) { case AzureClientSecretsConnectionMethod.OAuth: @@ -137,7 +137,7 @@ export const AzureClientSecretsConnectionForm = ({ appConnection, onSubmit }: Pr break; case AzureClientSecretsConnectionMethod.ClientSecret: - onSubmit(formData); + await onSubmit(formData); break; default: throw new Error(`Unhandled Azure Connection method: ${(formData as FormData).method}`); @@ -240,7 +240,11 @@ export const AzureClientSecretsConnectionForm = ({ appConnection, onSubmit }: Pr label="Client Secret" errorText={error?.message} > - + )} /> diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureDevOpsConnectionForm.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureDevOpsConnectionForm.tsx index f8f0572dc..c4511a0da 100644 --- a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureDevOpsConnectionForm.tsx +++ b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureDevOpsConnectionForm.tsx @@ -172,10 +172,10 @@ export const AzureDevOpsConnectionForm = ({ appConnection, onSubmit }: Props) => ); break; case AzureDevOpsConnectionMethod.AccessToken: - onSubmit(formData); + await onSubmit(formData); break; case AzureDevOpsConnectionMethod.ClientSecret: - onSubmit(formData); + await onSubmit(formData); break; default: throw new Error(`Unhandled Azure Connection method: ${(formData as FormData).method}`); @@ -303,7 +303,11 @@ export const AzureDevOpsConnectionForm = ({ appConnection, onSubmit }: Props) => label="Client Secret" errorText={error?.message} > - + )} /> diff --git a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureKeyVaultConnectionForm.tsx b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureKeyVaultConnectionForm.tsx index ac1d3705c..ed99fda01 100644 --- a/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureKeyVaultConnectionForm.tsx +++ b/frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionForm/AzureKeyVaultConnectionForm.tsx @@ -120,7 +120,7 @@ export const AzureKeyVaultConnectionForm = ({ appConnection, onSubmit }: Props) const selectedMethod = watch("method"); - const onSubmitHandler = (formData: FormData) => { + const onSubmitHandler = async (formData: FormData) => { const state = crypto.randomBytes(16).toString("hex"); switch (formData.method) { @@ -136,7 +136,7 @@ export const AzureKeyVaultConnectionForm = ({ appConnection, onSubmit }: Props) ); break; case AzureKeyVaultConnectionMethod.ClientSecret: - onSubmit(formData); + await onSubmit(formData); break; default: throw new Error(`Unhandled Azure Connection method: ${(formData as FormData).method}`); @@ -251,7 +251,11 @@ export const AzureKeyVaultConnectionForm = ({ appConnection, onSubmit }: Props) label="Client Secret" errorText={error?.message} > - + )} />