From cd6be68461efddd5ce084f11e55de9d57f6bcba4 Mon Sep 17 00:00:00 2001
From: Daniel Hougaard <62331820+DanielHougaard@users.noreply.github.com>
Date: Wed, 3 Apr 2024 16:39:15 -0700
Subject: [PATCH] Fix: Validate approvers access

---
 .../access-approval-policy/access-approval-policy-service.ts    | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/backend/src/ee/services/access-approval-policy/access-approval-policy-service.ts b/backend/src/ee/services/access-approval-policy/access-approval-policy-service.ts
index f5cce5db4..f14380869 100644
--- a/backend/src/ee/services/access-approval-policy/access-approval-policy-service.ts
+++ b/backend/src/ee/services/access-approval-policy/access-approval-policy-service.ts
@@ -54,6 +54,7 @@ export const accessApprovalPolicyServiceFactory = ({
 
     if (approvals > approvers.length)
       throw new BadRequestError({ message: "Approvals cannot be greater than approvers" });
+    if (!secretPath) throw new BadRequestError({ message: "Secret path is required" });
 
     const { permission } = await permissionService.getProjectPermission(
       actor,
@@ -154,6 +155,7 @@ export const accessApprovalPolicyServiceFactory = ({
       actorAuthMethod,
       actorOrgId
     );
+
     ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Edit, ProjectPermissionSub.SecretApproval);
 
     const updatedPolicy = await accessApprovalPolicyDAL.transaction(async (tx) => {